chore: Add FDv2 Polling Data Source #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctional-data-source-updates
…rlamb/sdk-1584/fdv2-polling-data-source
…rlamb/sdk-1584/fdv2-polling-data-source
…rlamb/sdk-1584/fdv2-polling-data-source
kinyoklion
force-pushed
the
rlamb/sdk-1584/fdv2-polling-data-source
branch
4 times, most recently
from
0273b89 to
bfa1caa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
pkgs/sdk/server/src/Internal/FDv2DataSources/FDv2PollingDataSource.cs
Outdated
Show resolved
Hide resolved
kinyoklion
force-pushed
the
rlamb/sdk-1584/fdv2-polling-data-source
branch
2 times, most recently
from
aa1998d to
0187fcf
Compare
kinyoklion
force-pushed
the
rlamb/sdk-1584/fdv2-polling-data-source
branch
from
0187fcf to
aee3377
Compare
Member
Author
|
bugbot review |
kinyoklion
commented
Dec 5, 2025
| _log.Debug("Get all flags returned 304: not modified"); | ||
| return null; | ||
| } | ||
| //We ensure the status code after checking for 304, because 304 isn't considered success |
Member
Author
There was a problem hiding this comment.
I removed this comment because it was blatantly wrong. A 304 is a success, and this code doesn't even run when there is a 304 because we return above. (I looked back through the history and it has been incorrect since addition 9 years ago.)
pkgs/sdk/server/src/Internal/FDv2DataSources/FDv2PollingRequestor.cs
Outdated
Show resolved
Hide resolved
tanderson-ld
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Can this be FDv2Requestor? The only logic inside it that is specific to polling is the logs. I know off the top of my head iOS and Node have Requestor classes that are separable from the polling itself.
Member
Author
There was a problem hiding this comment.
The payload it produces is not agnostic, so I am not sure.
Member
Author
There was a problem hiding this comment.
We can always change it though, as it is internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Implements FDv2 polling (requestor + data source) with event-array parsing, ETag/304 handling, status updates, env-id header extraction, and comprehensive tests.
Internal/FDv2DataSources/FDv2PollingDataSource.csimplementing periodic polling, processing protocol actions, applying transactional changesets, marking initialization, updatingDataSourceStatus, and handling JSON/HTTP errors.Internal/FDv2DataSources/FDv2PollingRequestor.csbuilding requests with selector query params, ETag caching, 304 handling, header capture (includingx-ld-envid), and deserializing pollingevents.IFDv2PollingRequestor.csdefiningFDv2PollingResponseand requestor interface.Internal/FDv2Payloads/FDv2Event.csaddsDeserializeEventsArrayand poll-event converter usage for parsingeventsarrays with strict validation.FDv2StreamingDataSource.cs(no functional change in this diff).Internal/DataSources/FeatureRequestor.cs.test/Internal/FDv2DataSources/FDv2PollingDataSourceTest.cscovering init, full/partial updates, deletes, 304 behavior, error/status transitions, selector propagation, and env-id extraction.test/Internal/FDv2Payloads/FDv2PayloadsTest.csforDeserializeEventsArrayand valid/invalid payload scenarios.Written by Cursor Bugbot for commit 69b18d1. This will update automatically on new commits. Configure here.