Skip to content

ci: Fix build error #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
+26 −1
Merged

ci: Fix build error #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4daadbc
Ignore eol workloads
keelerm84 Feb 4, 2025
056da97
Use global.json
keelerm84 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/actions/ci/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,14 @@ runs:
- name: Setup dotnet build tools
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
dotnet-version: |
6.0
7.0

- name: Copy global.json in place
shell: bash
run: cp global.example.json global.json

- name: Restore Workloads
shell: bash
run: dotnet workload restore ${{ inputs.project_file }}
Expand All @@ -44,3 +48,7 @@ runs:
run: |
dotnet restore ${{ inputs.test_project_file }}
dotnet test -v=${{ inputs.test_verbosity }} --framework=${{ inputs.target_test_framework }} ${{ inputs.test_project_file }}

- name: Remove global.json
shell: bash
run: rm global.json
8 changes: 8 additions & 0 deletions .github/actions/contract-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ runs:
with:
dotnet-version: 6.0

- name: Restore Workloads
shell: bash
run: dotnet workload restore ${{ inputs.service_project_file }}

- name: Restore Dependencies
shell: bash
run: dotnet restore ${{ inputs.service_project_file }}

- name: Build Contract Tests
shell: bash
run: dotnet build -p:Configuration=debug ${{ inputs.service_project_file }}
Expand Down
6 changes: 6 additions & 0 deletions global.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"sdk": {
"version": "7.0.410",
"rollForward": "latestFeature"
}
}
1 change: 1 addition & 0 deletions pkgs/sdk/client/src/LaunchDarkly.ClientSdk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<RootNamespace>LaunchDarkly.Sdk.Client</RootNamespace>
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
<CheckEolWorkloads>false</CheckEolWorkloads>
Copy link
Member

@kinyoklion kinyoklion Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe @tanderson-ld was looking at updating the workloads? It would be better to not be using EOL workloads.


<!-- fail if XML comments are missing or invalid -->
<WarningsAsErrors>1570,1571,1572,1573,1574,1580,1581,1584,1591,1710,1711,1712</WarningsAsErrors>
Expand Down
2 changes: 2 additions & 0 deletions pkgs/sdk/server-ai/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ test:

clean:
dotnet clean

.PHONY: build test clean
Loading