This repository was archived by the owner on Oct 11, 2019. It is now read-only.
Bounded resource consumption refactoring #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Stops the LaunchDarkly client from sending any additional events. | ||
| // Shuts down the LaunchDarkly client. After calling this, the LaunchDarkly client |
There was a problem hiding this comment.
comment on exported method LDClient.Close should be of the form "Close ..."
| } | ||
|
|
||
| var ErrInitializationTimeout = errors.New("Timeout encountered waiting for LaunchDarkly client initialization") | ||
| var ErrClientNotInitialized = errors.New("Toggle called before LaunchDarkly client initialization completed") |
There was a problem hiding this comment.
exported var ErrClientNotInitialized should have comment or be unexported
Contributor
|
This all seems reasonable. +1 for talking about this in person. |
| } | ||
|
|
||
| // Stops the LaunchDarkly client from sending any additional events. | ||
| // Shuts down the LaunchDarkly client. After calling this, the LaunchDarkly client |
There was a problem hiding this comment.
comment on exported method LDClient.Close should be of the form "Close ..."
Contributor
|
lgtm |
jkodumal
added a commit
that referenced
this pull request
Feb 23, 2016
…tion Bounded resource consumption refactoring
|
|
||
| store = config.FeatureStore | ||
|
|
||
| if !config.UseLdd && !config.Offline { |
Contributor
Author
There was a problem hiding this comment.
If LDD mode is set, then we will always timeout.
This was referenced Apr 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed approach to bounding resource consumption in the go client. I also think this should be the reference model for all SDKs (save PHP and to a certain degree mobile) going forward. There are a number of ideas in here:
updateProcessorabstraction, so we're more cleanly separating the process of updating the feature store from reading the feature storeupdateProcessorimplementationLDClient, and we no longer ask it whether it's initialized. This is potentially a big performance win because we no longer make a remote redis call to check initialization on every toggle call.There's probably more here, so it's worth going over this in person as a group. But here is the first cut of it for early feedback.