Skip to content

Conversation

@kinyoklion
Copy link
Member

No description provided.

@kinyoklion kinyoklion marked this pull request as ready for review December 6, 2024 18:34
@kinyoklion kinyoklion requested a review from keelerm84 December 6, 2024 18:35
@kinyoklion kinyoklion enabled auto-merge (squash) December 6, 2024 18:35
Comment on lines +30 to +33
if (!sdkKey) {
console.log('*** Please edit index.js to set sdkKey to your LaunchDarkly SDK key first.');
process.exit(1);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have this, should we not default the SDK variable above to "your-sdk-key"?

@kinyoklion kinyoklion merged commit c65a760 into main Dec 6, 2024
1 check passed
@kinyoklion kinyoklion deleted the rlamb/ide-668/migrate-github-actions branch December 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants