Fixed Xcode 10 error: Multiple commands produce

[jbfitb]

Issue

• Getting the following errors when building with xcode 10:

Build system information
error: Multiple commands produce '/Users/me/build/sandbox/Release/Build/Products/Release-iphonesimulator/Darkly.framework/Darkly':
1) Target 'Darkly_iOS' has a command with output '/Users/me/build/sandbox/Release/Build/Products/Release-iphonesimulator/Darkly.framework/Darkly'
2) Target 'Darkly_osx' has a command with output '/Users/me/build/sandbox/Release/Build/Products/Release-iphonesimulator/Darkly.framework/Darkly'

See #145 (comment)

Change

• Rename macOS, watchOS, and tvOS versions to match their bundle names

[markpokornycos]

@jbfitbit I have a quick question. When you made this change, it adds the platform to the framework name. Did you have to change your imports to reflect the new framework name?

Thank you!

[jbfitb]

That's a good question. I have been using the iOS version which kept the same name.

[markpokornycos]

@jbfitbit The "-" in the framework names prevent the framework from being recognized in an import statement in some situations. I'm going to accept this PR and merge into renamedFrameworks and then change the names to replace the "-" with "_".

[markpokornycos]

Post merge I will modify the framework names to replace "-" with "_".

[daveluong]

Log -> carthage-xcodebuild.8sRM6c.log

** Checking out ios-client at "9b3a96d2e98853d6c15dd06bbe8c80bf24cf3a25"
*** xcodebuild output can be found in /var/folders/m_/b6xbzm2n559fy5kf1gcljdch0000gn/T/carthage-xcodebuild.8sRM6c.log
*** Building scheme "Darkly_iOS" in Darkly.xcworkspace
Build Failed
	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -workspace /Users/daveluong/Developer/Work/*/Carthage/Checkouts/ios-client/Darkly.xcworkspace -scheme Darkly_iOS -configuration Release -derivedDataPath /Users/daveluong/Library/Caches/org.carthage.CarthageKit/DerivedData/10.2_10E125/ios-client/9b3a96d2e98853d6c15dd06bbe8c80bf24cf3a25 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/m_/b6xbzm2n559fy5kf1gcljdch0000gn/T/ios-client SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/daveluong/Developer/Work/*/Carthage/Checkouts/ios-client)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/m_/b6xbzm2n559fy5kf1gcljdch0000gn/T/carthage-xcodebuild.8sRM6c.log

Hey guys, im getting this failure trying to build this branch with XCode 10.2