Skip to content

fix: Add default implementation for hook methods #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2024
Merged

fix: Add default implementation for hook methods #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ff215
fix: Add default implementation for hook methods
keelerm84 May 17, 2024
b2a8ae8
Limit swift lint version
keelerm84 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/ci/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ runs:
with:
xcode-version: ${{ inputs.xcode-version }}

- name: Install mint and swiftlint
- name: Install mint
shell: bash
run: |
brew tap mint-lang/mint-lang
brew install mint-lang swiftlint libressl
brew install mint-lang libressl

- name: Install cocoapods
shell: bash
Expand Down
14 changes: 14 additions & 0 deletions LaunchDarkly/LaunchDarkly/Models/Hooks/Hook.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,17 @@ public protocol Hook {
/// determined. The method is executed synchronously.
func afterEvaluation(seriesContext: EvaluationSeriesContext, seriesData: EvaluationSeriesData, evaluationDetail: LDEvaluationDetail<LDValue>) -> EvaluationSeriesData
}

public extension Hook {
func metadata() -> Metadata {
return Metadata(name: "UNDEFINED")
}

func beforeEvaluation(seriesContext: EvaluationSeriesContext, seriesData: EvaluationSeriesData) -> EvaluationSeriesData {
return seriesData
}

func afterEvaluation(seriesContext: EvaluationSeriesContext, seriesData: EvaluationSeriesData, evaluationDetail: LDEvaluationDetail<LDValue>) -> EvaluationSeriesData {
return seriesData
}
}