Merge pull request #47 from launchdarkly/dr/VariationNullCheck

Add support for debugStreaming config param. Add null check in Variation.equals()

Author: drichelson

src/main/java/com/launchdarkly/client/LDClient.java

@@ -200,7 +200,14 @@ private boolean evaluate(String featureKey, LDUser user, boolean defaultValue) {
 
     try {
       FeatureRep<Boolean> result = (FeatureRep<Boolean>) config.featureStore.get(featureKey);
-      if (result == null) {
+      if (result != null) {
+        if (config.stream && config.debugStreaming) {
+          FeatureRep<Boolean> pollingResult = requestor.makeRequest(featureKey, true);
+          if (!result.equals(pollingResult)) {
+            logger.warn("Mismatch between streaming and polling feature! Streaming: {} Polling: {}", result, pollingResult);
+          }
+        }
+      } else {
         logger.warn("Unknown feature flag " + featureKey + "; returning default value: ");
         return defaultValue;
       }

src/main/java/com/launchdarkly/client/Variation.java

@@ -39,18 +39,17 @@ public boolean equals(Object o) {
     Variation<?> variation = (Variation<?>) o;
 
     if (weight != variation.weight) return false;
-    if (!value.equals(variation.value)) return false;
-    if (!userTarget.equals(variation.userTarget)) return false;
-    return targets.equals(variation.targets);
-
+    if (value != null ? !value.equals(variation.value) : variation.value != null) return false;
+    if (userTarget != null ? !userTarget.equals(variation.userTarget) : variation.userTarget != null) return false;
+    return targets != null ? targets.equals(variation.targets) : variation.targets == null;
   }
 
   @Override
   public int hashCode() {
-    int result = value.hashCode();
+    int result = value != null ? value.hashCode() : 0;
     result = 31 * result + weight;
-    result = 31 * result + userTarget.hashCode();
-    result = 31 * result + targets.hashCode();
+    result = 31 * result + (userTarget != null ? userTarget.hashCode() : 0);
+    result = 31 * result + (targets != null ? targets.hashCode() : 0);
     return result;
   }