This repository was archived by the owner on May 30, 2024. It is now read-only.
fixed logic for rules written using non-string values #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
This expands the API in a backward-compatible way, so the next version will be 0.9.0.
Also, we have a bunch of overloaded custom methods, to set values of different types, but you can only set a list of strings (because of type erasure, we can't have a method named custom that takes a list of numbers).
So, should we encode the type in the method names (eg, customNumber(String, Number) / customNumbers(String, List<Number>), customBool(String, Boolean) / customBools(String, List<Boolean>), customString(String, String) / customStrings(String, List<String>))? Or another idea?
Contributor
|
lgtm |
pkaeding
added a commit
that referenced
this pull request
Jun 30, 2015
fixed logic for rules written using non-string values
pkaeding
added a commit
that referenced
this pull request
Sep 25, 2015
fixed logic for rules written using non-string values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.