fix: remove rollup-plugin-dts dependency#1288
Conversation
|
@cursor review |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk-common size report |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit de95959. Configure here.
🤖 I have created a release *beep* *boop* --- <details><summary>browser: 0.1.15</summary> ## [0.1.15](browser-v0.1.14...browser-v0.1.15) (2026-04-17) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from 4.5.0 to 4.6.0 </details> <details><summary>browser-telemetry: 1.0.31</summary> ## [1.0.31](browser-telemetry-v1.0.30...browser-telemetry-v1.0.31) (2026-04-17) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-client-sdk bumped from 4.5.0 to 4.6.0 </details> <details><summary>cloudflare-server-sdk: 2.7.19</summary> ## [2.7.19](cloudflare-server-sdk-v2.7.18...cloudflare-server-sdk-v2.7.19) (2026-04-17) ### Bug Fixes * remove `rollup-plugin-dts` dependency ([#1288](#1288)) ([ea64b82](ea64b82)) </details> <details><summary>jest: 1.0.10</summary> ## [1.0.10](jest-v1.0.9...jest-v1.0.10) (2026-04-17) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/react-native-client-sdk bumped from ~10.15.2 to ~10.16.0 </details> <details><summary>js-client-sdk: 4.6.0</summary> ## [4.6.0](js-client-sdk-v4.5.0...js-client-sdk-v4.6.0) (2026-04-17) ### Features * adding start() method to common client sdk package ([#1244](#1244)) ([7f5f468](7f5f468)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.24.0 to 1.25.0 </details> <details><summary>js-client-sdk-common: 1.25.0</summary> ## [1.25.0](js-client-sdk-common-v1.24.0...js-client-sdk-common-v1.25.0) (2026-04-17) ### Features * Add experimental FDv2 support for React Native. ([#1243](#1243)) ([7ed2c08](7ed2c08)) * adding start() method to common client sdk package ([#1244](#1244)) ([7f5f468](7f5f468)) ### Bug Fixes * FDv2 -- cache initializer returns transfer-none on cache miss ([#1275](#1275)) ([7bf3c31](7bf3c31)) </details> <details><summary>react-native-client-sdk: 10.16.0</summary> ## [10.16.0](react-native-client-sdk-v10.15.2...react-native-client-sdk-v10.16.0) (2026-04-17) ### Features * Add experimental FDv2 support for React Native. ([#1243](#1243)) ([7ed2c08](7ed2c08)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.24.0 to 1.25.0 </details> <details><summary>react-sdk: 0.2.1</summary> ## [0.2.1](react-sdk-v0.2.0...react-sdk-v0.2.1) (2026-04-17) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from ^4.5.0 to ^4.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Mostly mechanical version/changelog updates, but it publishes new SDK versions (including new/experimental client capabilities) which could affect downstream consumers if the release contents are incorrect. > > **Overview** > Updates release metadata for a multi-package publish, bumping versions across the Browser, React Native, React, Cloudflare, combined-browser, browser-telemetry, and jest packages and updating their changelogs and example app dependencies accordingly. > > Also updates embedded `x-release-please-version` strings (for SDK/wrapper reporting) to match the new package versions. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d56c92d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Note
Medium Risk
Changes the build pipeline and TypeScript declaration output paths; risk is mainly around consumers resolving
.d.tscorrectly and the published package layout changing.Overview
Updates the Cloudflare SDK packaging to stop using
rollup-plugin-dts/rollup-plugin-esbuildand instead generate type declarations during the ESM Rollup build via@rollup/plugin-typescript.As part of this, the package’s
typesentrypoints are repointed fromdist/index.d.tstodist/esm/src/index.d.ts, and the Rollup config now emits declarations only for the ESM build while disabling them for CJS.Reviewed by Cursor Bugbot for commit de95959. Bugbot is set up for automated code reviews on this repo. Configure here.