Skip to content

fix: remove rollup-plugin-dts dependency#1288

Merged
joker23 merged 1 commit intomainfrom
skz/sdk-2202/remove-rollup-dts
Apr 17, 2026
Merged

fix: remove rollup-plugin-dts dependency#1288
joker23 merged 1 commit intomainfrom
skz/sdk-2202/remove-rollup-dts

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Apr 17, 2026

Note

Medium Risk
Changes the build pipeline and TypeScript declaration output paths; risk is mainly around consumers resolving .d.ts correctly and the published package layout changing.

Overview
Updates the Cloudflare SDK packaging to stop using rollup-plugin-dts/rollup-plugin-esbuild and instead generate type declarations during the ESM Rollup build via @rollup/plugin-typescript.

As part of this, the package’s types entrypoints are repointed from dist/index.d.ts to dist/esm/src/index.d.ts, and the Rollup config now emits declarations only for the ESM build while disabling them for CJS.

Reviewed by Cursor Bugbot for commit de95959. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Apr 17, 2026

@cursor review

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25623 bytes
Compressed size limit: 29000
Uncompressed size: 125843 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31731 bytes
Compressed size limit: 34000
Uncompressed size: 113100 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179425 bytes
Compressed size limit: 200000
Uncompressed size: 830289 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37607 bytes
Compressed size limit: 38000
Uncompressed size: 207149 bytes

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit de95959. Configure here.

@joker23 joker23 marked this pull request as ready for review April 17, 2026 16:50
@joker23 joker23 requested a review from a team as a code owner April 17, 2026 16:50
@joker23 joker23 merged commit ea64b82 into main Apr 17, 2026
47 of 51 checks passed
@joker23 joker23 deleted the skz/sdk-2202/remove-rollup-dts branch April 17, 2026 16:51
@github-actions github-actions bot mentioned this pull request Apr 17, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

joker23 pushed a commit that referenced this pull request Apr 17, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>browser: 0.1.15</summary>

##
[0.1.15](browser-v0.1.14...browser-v0.1.15)
(2026-04-17)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk bumped from 4.5.0 to 4.6.0
</details>

<details><summary>browser-telemetry: 1.0.31</summary>

##
[1.0.31](browser-telemetry-v1.0.30...browser-telemetry-v1.0.31)
(2026-04-17)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-client-sdk bumped from 4.5.0 to 4.6.0
</details>

<details><summary>cloudflare-server-sdk: 2.7.19</summary>

##
[2.7.19](cloudflare-server-sdk-v2.7.18...cloudflare-server-sdk-v2.7.19)
(2026-04-17)


### Bug Fixes

* remove `rollup-plugin-dts` dependency
([#1288](#1288))
([ea64b82](ea64b82))
</details>

<details><summary>jest: 1.0.10</summary>

##
[1.0.10](jest-v1.0.9...jest-v1.0.10)
(2026-04-17)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/react-native-client-sdk bumped from ~10.15.2 to ~10.16.0
</details>

<details><summary>js-client-sdk: 4.6.0</summary>

##
[4.6.0](js-client-sdk-v4.5.0...js-client-sdk-v4.6.0)
(2026-04-17)


### Features

* adding start() method to common client sdk package
([#1244](#1244))
([7f5f468](7f5f468))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.24.0 to 1.25.0
</details>

<details><summary>js-client-sdk-common: 1.25.0</summary>

##
[1.25.0](js-client-sdk-common-v1.24.0...js-client-sdk-common-v1.25.0)
(2026-04-17)


### Features

* Add experimental FDv2 support for React Native.
([#1243](#1243))
([7ed2c08](7ed2c08))
* adding start() method to common client sdk package
([#1244](#1244))
([7f5f468](7f5f468))


### Bug Fixes

* FDv2 -- cache initializer returns transfer-none on cache miss
([#1275](#1275))
([7bf3c31](7bf3c31))
</details>

<details><summary>react-native-client-sdk: 10.16.0</summary>

##
[10.16.0](react-native-client-sdk-v10.15.2...react-native-client-sdk-v10.16.0)
(2026-04-17)


### Features

* Add experimental FDv2 support for React Native.
([#1243](#1243))
([7ed2c08](7ed2c08))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.24.0 to 1.25.0
</details>

<details><summary>react-sdk: 0.2.1</summary>

##
[0.2.1](react-sdk-v0.2.0...react-sdk-v0.2.1)
(2026-04-17)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk bumped from ^4.5.0 to ^4.6.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Mostly mechanical version/changelog updates, but it publishes new SDK
versions (including new/experimental client capabilities) which could
affect downstream consumers if the release contents are incorrect.
> 
> **Overview**
> Updates release metadata for a multi-package publish, bumping versions
across the Browser, React Native, React, Cloudflare, combined-browser,
browser-telemetry, and jest packages and updating their changelogs and
example app dependencies accordingly.
> 
> Also updates embedded `x-release-please-version` strings (for
SDK/wrapper reporting) to match the new package versions.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d56c92d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants