fix: Fix issue that caused the feature store get function impl to be called twice #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #207639: Fix issue that caused the feature store get function impl to be called twice. |
ctawiah
changed the title
ctawiah
requested review from
kinyoklion,
louis-launchdarkly and
yusinto
as code owners
dariushar
approved these changes
Jun 22, 2023
ctawiah
deleted the
ctawiah/sc-207639/fix-code-that-caused-feature-store-twice-oninit
branch
Merged
ctawiah
pushed a commit
that referenced
this pull request
Jun 23, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 0.2.3</summary> ## [0.2.3](akamai-edgeworker-sdk-common-v0.2.2...akamai-edgeworker-sdk-common-v0.2.3) (2023-06-23) ### Bug Fixes * Fix issue that caused the feature store get function impl to be called twice ([#178](#178)) ([68f1c78](68f1c78)) </details> <details><summary>akamai-server-base-sdk: 0.4.2</summary> ## [0.4.2](akamai-server-base-sdk-v0.4.1...akamai-server-base-sdk-v0.4.2) (2023-06-23) ### Bug Fixes * Fix issue that caused the feature store get function impl to be called twice ([#178](#178)) ([68f1c78](68f1c78)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^0.2.2 to ^0.2.3 </details> <details><summary>akamai-server-edgekv-sdk: 0.4.2</summary> ## [0.4.2](akamai-server-edgekv-sdk-v0.4.1...akamai-server-edgekv-sdk-v0.4.2) (2023-06-23) ### Bug Fixes * Fix issue that caused the feature store get function impl to be called twice ([#178](#178)) ([68f1c78](68f1c78)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^0.2.2 to ^0.2.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/launchdarkly/story/207639
This PR adds a new
CacheableStoreProviderwrapper to Akamai Edge SDK to prevent redundant requests from being made to the origin store. This cacheable store provider ensure we're making only a single call per request thus removing duplicate sub-requests call which could be costly to our customers. With this fix, there will be only a single call made per method callvariation,variationDetailorallFlagsStateis called.Also added some unit test to validate duplicate calls are not made.