Skip to content

fix: Minor fixes from docs pr review. #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: Minor fixes from docs pr review. #363

merged 2 commits into from
Feb 7, 2024

Conversation

@yusinto
Copy link
Contributor

@yusinto yusinto commented Feb 7, 2024 •
edited
Loading

  • Corrected close to return a Promise.
  • Removed redundant EventName identifying.
  • Add missing type for getConnectionMode.

@shortcut-integration
Copy link

shortcut-integration bot commented Feb 7, 2024

This pull request has been linked to Shortcut Story #232687: More RN fixes from Docs review.

@yusinto yusinto merged commit 4768bf7 into main Feb 7, 2024
@yusinto yusinto deleted the yus/sc-232687/more-rn-fixes-from-docs-review branch February 7, 2024 00:50
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
Merged
yusinto pushed a commit that referenced this pull request Feb 7, 2024
@github-actions
chore: release main (#364)
03a2d2f 
🤖 I have created a release *beep* *boop*
---


<details><summary>js-client-sdk-common: 0.2.1</summary>

##
[0.2.1](js-client-sdk-common-v0.2.0...js-client-sdk-common-v0.2.1)
(2024-02-07)


### Bug Fixes

* Minor fixes from docs pr review.
([#363](#363))
([4768bf7](4768bf7))
</details>

<details><summary>react-native-client-sdk: 0.2.1</summary>

##
[0.2.1](react-native-client-sdk-v0.2.0...react-native-client-sdk-v0.2.1)
(2024-02-07)


### Bug Fixes

* Babel TypeError due to event-target-shim
([#365](#365))
([c1c0086](c1c0086))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 0.2.0 to 0.2.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinyoklion kinyoklion Awaiting requested review from kinyoklion

1 more reviewer

@louis-launchdarkly louis-launchdarkly louis-launchdarkly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yusinto @louis-launchdarkly