feat: JSR support for Cloudflare SDK. #415

yusinto · 2024-04-01T21:24:41Z

No description provided.

…ild to latest version. Set cf sdk to jsr.

shortcut-integration · 2024-04-01T21:24:45Z

This pull request has been linked to Shortcut Story #236785: Investigate publishing to JSR.

yusinto · 2024-04-01T21:26:51Z

packages/sdk/cloudflare/src/createPlatformInfo.ts

-import { name, version } from '../package.json';
+// @ts-ignore
+// eslint-disable-next-line prettier/prettier
+import * as packageJson from '../package.json' assert { type: "json" }


This import assertion is new-ish and is not yet fully supported by jest and prettier. I took a shortcut here and ignore this for now to save time. Hopefully in time we can just remove these ignores.

kinyoklion · 2024-04-01T21:31:51Z

packages/sdk/cloudflare/example/package.json

    "@cloudflare/workers-types": "^4.20230321.0",
    "@types/jest": "^29.5.5",
-    "esbuild": "^0.14.41",
+    "esbuild": "0.20.2",


Is this intentionally pinned?

I've carot'd it.

yusinto · 2024-04-01T21:27:36Z

.prettierignore

 .vscode
 **/*/CHANGELOG.md
 packages/sdk/akamai-edgekv/src/edgekv/edgekv.js
+packages/sdk/cloudflare/src/createPlatformInfo.ts


@trivago/prettier-plugin-sort-imports doesn't like the new-ish import assertion syntax. See my comments here.

yusinto · 2024-04-01T21:31:01Z

packages/sdk/cloudflare/example/package.json

    "@cloudflare/workers-types": "^4.20230321.0",
    "@types/jest": "^29.5.5",
-    "esbuild": "^0.14.41",
+    "esbuild": "0.20.2",


Use the latest version of esbuild to get import assertion support.

yusinto · 2024-04-01T21:31:21Z

packages/sdk/cloudflare/example/src/index.ts

 export default {
  async fetch(request: Request, env: Bindings, ctx: ExecutionContext): Promise<Response> {
-    const clientSideID = 'test-client-side-id';
+    const clientSideID = 'test-sdk-key';


This was inconsistent with the README so it's kinda like a bugfix.

yusinto · 2024-04-01T21:32:13Z

packages/sdk/cloudflare/jsr.json

This is the jsr equivalent of package.json. It's used during publishing. The version is hardcoded atm, but I'll submit a separate PR to implement publishing through release-please.

yusinto · 2024-04-01T21:33:17Z

packages/sdk/cloudflare/src/index.ts

JSR publish command complained about these so I corrected them.

kinyoklion · 2024-04-01T21:32:56Z

packages/sdk/cloudflare/jsr.json

@@ -0,0 +1,9 @@
+{
+  "name": "@launchdarkly/cloudflare-server-sdk",
+  "version": "0.0.3",


Release please will need to be able to update this. If it is fine for it to re-write the file each time, then you can use the JSON updater.

I think it would be like this.

{ "extra-files": [ { "type": "json", "path": "jsr.json", "jsonpath": "$.version" } ] }

Yes you are right. I was going to submit a separate PR for the RP work. Maybe i'll just do it together in this PR now that you mentioned it.

I will do this in a separate pr focussed on publishing in CI.

louis-launchdarkly · 2024-04-01T21:39:29Z

packages/sdk/cloudflare/example/README.md

+5. Edit [index.ts](https://github.com/launchdarkly/js-core/blob/main/packages/sdk/cloudflare/example/src/index.ts#L6) to use your clientSideID and a valid flag key from the test data you just inserted.
+
+```ts
+    const clientSideID = 'test-sdk-key';


My assumption is that there is clear documentation somewhere explaining this (as SDK Key is the terminology we typically use for Server-Side) - we need the Client-side ID for the events here, is that correct?

We need the clientSideID yes. I will correct them all to clientSideID to be consistent.

🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 1.1.3</summary> ## [1.1.3](akamai-edgeworker-sdk-common-v1.1.2...akamai-edgeworker-sdk-common-v1.1.3) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.2.2 to ^2.2.3 </details> <details><summary>akamai-server-base-sdk: 2.1.3</summary> ## [2.1.3](akamai-server-base-sdk-v2.1.2...akamai-server-base-sdk-v2.1.3) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.2 to ^1.1.3 * @launchdarkly/js-server-sdk-common bumped from ^2.2.2 to ^2.2.3 </details> <details><summary>akamai-server-edgekv-sdk: 1.1.3</summary> ## [1.1.3](akamai-server-edgekv-sdk-v1.1.2...akamai-server-edgekv-sdk-v1.1.3) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.2 to ^1.1.3 * @launchdarkly/js-server-sdk-common bumped from ^2.2.2 to ^2.2.3 </details> <details><summary>cloudflare-server-sdk: 2.5.0</summary> ## [2.5.0](cloudflare-server-sdk-v2.4.2...cloudflare-server-sdk-v2.5.0) (2024-04-09) ### Features * JSR support for Cloudflare SDK. ([#415](#415)) ([30866f3](30866f3)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.2.2 to 2.2.3 </details> <details><summary>js-client-sdk-common: 1.1.0</summary> ## [1.1.0](js-client-sdk-common-v1.0.3...js-client-sdk-common-v1.1.0) (2024-04-09) ### Features * Add identify timeout to client-sdk. ([#420](#420)) ([5d73dfe](5d73dfe)) ### Bug Fixes * Identify incorrectly rejected in client-sdk ([#426](#426)) ([a019dd6](a019dd6)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.3.1 to 2.4.0 </details> <details><summary>js-sdk-common: 2.4.0</summary> ## [2.4.0](js-sdk-common-v2.3.1...js-sdk-common-v2.4.0) (2024-04-09) ### Features * Add identify timeout to client-sdk. ([#420](#420)) ([5d73dfe](5d73dfe)) ### Bug Fixes * Identify incorrectly rejected in client-sdk ([#426](#426)) ([a019dd6](a019dd6)) </details> <details><summary>js-server-sdk-common: 2.2.3</summary> ## [2.2.3](js-server-sdk-common-v2.2.2...js-server-sdk-common-v2.2.3) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.3.1 to 2.4.0 </details> <details><summary>js-server-sdk-common-edge: 2.2.3</summary> ## [2.2.3](js-server-sdk-common-edge-v2.2.2...js-server-sdk-common-edge-v2.2.3) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.2.2 to 2.2.3 </details> <details><summary>node-server-sdk: 9.2.3</summary> ## [9.2.3](node-server-sdk-v9.2.2...node-server-sdk-v9.2.3) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.2.2 to 2.2.3 </details> <details><summary>node-server-sdk-dynamodb: 6.1.6</summary> ## [6.1.6](node-server-sdk-dynamodb-v6.1.5...node-server-sdk-dynamodb-v6.1.6) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.2.2 to 9.2.3 * peerDependencies * @launchdarkly/node-server-sdk bumped from 9.2.1 to 9.2.3 </details> <details><summary>node-server-sdk-redis: 4.1.6</summary> ## [4.1.6](node-server-sdk-redis-v4.1.5...node-server-sdk-redis-v4.1.6) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.2.2 to 9.2.3 * peerDependencies * @launchdarkly/node-server-sdk bumped from 9.2.1 to 9.2.3 </details> <details><summary>react-native-client-sdk: 10.1.0</summary> ## [10.1.0](react-native-client-sdk-v10.0.5...react-native-client-sdk-v10.1.0) (2024-04-09) ### Features * Add identify timeout to client-sdk. ([#420](#420)) ([5d73dfe](5d73dfe)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.0.3 to 1.1.0 </details> <details><summary>vercel-server-sdk: 1.3.4</summary> ## [1.3.4](vercel-server-sdk-v1.3.3...vercel-server-sdk-v1.3.4) (2024-04-09) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.2.2 to 2.2.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com>

yusinto added 19 commits March 20, 2024 20:34

Create jsr.json

31b96cc

fix: Added explicit return types.

c39756b

Merge branch 'main' into yus/sc-236785/investigate-publishing-to-jsr

ca2cf35

fix: Include jsr.json when publishing.

05353a3

Merge branch 'main' into yus/sc-236785/investigate-publishing-to-jsr

0303885

fix: Modify package.json import to resolve esbuild error. Update esbu…

cde1ba4

…ild to latest version. Set cf sdk to jsr.

chore: Added jsr registry to npmrc and yarnrc.

2c305ca

Update .prettierrc

fba552a

Update .gitignore

af96d82

Update jsr.json

8f06f60

Update package.json

5e014f8

Merge branch 'main' into yus/sc-236785/investigate-publishing-to-jsr

4c20848

fix: Prettier ignore import assert.

e588616

fix: ts-ignore for import assertion because ts-jest errors.

cc7f0dc

chore: Corrected example sdk key. Updated example README.

b416c41

chore: Added jsr instructions.

117363c

chore: Reverted example cf sdk version.

a7d7dae

chore: Minor readme and version updates after testing.

4fdab2a

Delete .npmrc

55feca3

yusinto requested review from kinyoklion and louis-launchdarkly as code owners April 1, 2024 21:24

yusinto commented Apr 1, 2024

View reviewed changes

chore: Remove trailingCommas setting because its redundant.

9c9ca3c

kinyoklion reviewed Apr 1, 2024

View reviewed changes

yusinto commented Apr 1, 2024

View reviewed changes

Update package.json

4b29910

yusinto requested a review from kinyoklion April 1, 2024 21:34

kinyoklion requested changes Apr 1, 2024

View reviewed changes

kinyoklion approved these changes Apr 1, 2024

View reviewed changes

louis-launchdarkly reviewed Apr 1, 2024

View reviewed changes

chore: Replace all instances of sdkKey with clientSideID.

f2cbc4f

yusinto requested a review from louis-launchdarkly April 1, 2024 21:50

louis-launchdarkly approved these changes Apr 1, 2024

View reviewed changes

yusinto merged commit 30866f3 into main Apr 1, 2024

yusinto deleted the yus/sc-236785/investigate-publishing-to-jsr branch April 1, 2024 23:31

github-actions bot mentioned this pull request Apr 1, 2024

chore: release main #418

Merged

feat: JSR support for Cloudflare SDK. #415

feat: JSR support for Cloudflare SDK. #415

Uh oh!

Conversation

yusinto commented Apr 1, 2024

Uh oh!

shortcut-integration bot commented Apr 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants