feat: Added react-universal code from labs. #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixed exports. Exclude example from eslint.
…hub.com/launchdarkly/js-core into yus/sc-248499/move-ld-nextjs-to-js-core
yusinto
commented
Jun 27, 2024
…hub.com/launchdarkly/js-core into yus/sc-248499/move-ld-nextjs-to-js-core
kinyoklion
reviewed
Jun 27, 2024
kinyoklion
reviewed
Jun 27, 2024
yusinto
commented
Jun 27, 2024
| }, | ||
| "dependencies": { | ||
| "@launchdarkly/node-server-sdk": "workspace:^", | ||
| "launchdarkly-js-client-sdk": "^3.4.0" |
Contributor
Author
There was a problem hiding this comment.
Callout: Use the classic js sdk for now.
yusinto
commented
Jun 27, 2024
| "stripInternal": true, | ||
| "target": "ES2017", | ||
| "types": ["jest", "node"] | ||
| "types": ["jest", "node", "react/canary"], |
Contributor
Author
There was a problem hiding this comment.
Callout: Need react/canary to be able to use react cache. Nextjs does this so I'm not feeling too bad about it.
kinyoklion
reviewed
Jun 27, 2024
yusinto
commented
Jun 27, 2024
| const context = { kind: 'user', key: 'test-user-2' }; | ||
| (ldc as JSSdk).identify(context).then(() => { | ||
| console.log('identify successful, persisting to cookies'); | ||
| setCookie('ld', context); |
Contributor
Author
There was a problem hiding this comment.
setCookie automatically stringifies the cookie value.
yusinto
commented
Jun 27, 2024
| ## Usage | ||
|
|
||
| 1. Enable [instrumentationHook](https://nextjs.org/docs/app/building-your-application/optimizing/instrumentation) in `next.config.mjs`: | ||
| 1. On server start, initialize the Node Server SDK. If you are using NextJS App Router, do this in `instrumentation.ts`. You'll need to enable the [instrumentationHook](https://nextjs.org/docs/app/building-your-application/optimizing/instrumentation): |
Contributor
Author
There was a problem hiding this comment.
This universal sdk should work with all framework which supports rsc (gatsby, remix, etc).
kinyoklion
reviewed
Jun 27, 2024
packages/sdk/react-universal/example/app/components/helloClientComponent.tsx
Show resolved
Hide resolved
kinyoklion
reviewed
Jun 27, 2024
… todo to implement variation hooks.
kinyoklion
reviewed
Jul 1, 2024
kinyoklion
reviewed
Jul 1, 2024
kinyoklion
reviewed
Jul 1, 2024
kinyoklion
approved these changes
Jul 2, 2024
Merged
yusinto
added a commit
that referenced
this pull request
Jul 2, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>react-native-client-sdk: 10.2.0</summary> ## [10.2.0](react-native-client-sdk-v10.1.5...react-native-client-sdk-v10.2.0) (2024-07-02) ### Features * Added react-universal code. ([#493](#493)) ([e1d2d30](e1d2d30)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.