fix: Make it more clear what is happening when an event source is connecting. #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Jul 17, 2024
| .mockImplementationOnce(() => 0.888) | ||
| .mockImplementationOnce(() => 0.999); | ||
|
|
||
| mockXhr = { |
Member
Author
There was a problem hiding this comment.
I made a mock XHR so it makes the request to this instead of a general request.
I did this because I made the event source open method private, because it should be private.
We should make these tests respond to the XHR responses instead of directly manipulating the event source, but that was out of scope for the problem I wanted to resolve.
kinyoklion
commented
Jul 17, 2024
| private url: string; | ||
| private xhr: XMLHttpRequest = new XMLHttpRequest(); | ||
| private pollTimer: any; | ||
| private connectTimer: any; |
Member
Author
There was a problem hiding this comment.
Changed the name to reflect what it is doing.
kinyoklion
commented
Jul 17, 2024
| } | ||
|
|
||
| this.connectTimer = setTimeout(() => { | ||
| if(!initialConnection) { |
Member
Author
There was a problem hiding this comment.
Nothing to close for the first connection.
louis-launchdarkly
approved these changes
Jul 18, 2024
tanderson-ld
approved these changes
Jul 18, 2024
Merged
kinyoklion
added a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>react-native-client-sdk: 10.3.0</summary> ## [10.3.0](react-native-client-sdk-v10.2.1...react-native-client-sdk-v10.3.0) (2024-07-19) ### Features * Update expo and RN version used in example. ([#520](#520)) ([b8384c4](b8384c4)) ### Bug Fixes * Make it more clear what is happening when an event source is connecting. ([#518](#518)) ([52055ba](52055ba)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event source was treating the initial connection as a re-connection. This results in confusing messaging.
This also changes the retrying event, which we do not expose.
When we convert our polyfill to typescript we should use it instead and allow passing a connection method. The reason this is being used is theoretically an issue with fetch not streaming in RN, so it uses an XHR instead.