Skip to content

feat: Refactor application state handling. #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 30, 2024
Merged

feat: Refactor application state handling. #523

merged 12 commits into from
Jul 30, 2024

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Jul 29, 2024

No description provided.

kinyoklion
kinyoklion commented Jul 29, 2024
View reviewed changes
packages/sdk/react-native/src/provider/useAppState.ts
@@ -1,58 +0,0 @@
import { useEffect, useRef } from 'react';
Copy link
Member Author

@kinyoklion kinyoklion Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contained this big problem that needs resolved. The event source, which isn't the only update processor type possible, was being accessed via the platform.

kinyoklion
kinyoklion commented Jul 29, 2024
View reviewed changes
packages/sdk/react-native/src/provider/LDProvider.tsx
setupListeners(client, setState);
}, []);

useAppState(client);
Copy link
Member Author

@kinyoklion kinyoklion Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another problem with this is that the overall desired connection mode would fight with the connection mode determined by the "app state".

If you tell the client to be offline, then you don't expect a foreground transition to set it back online, for example.

@kinyoklion kinyoklion marked this pull request as ready for review July 29, 2024 22:49
@kinyoklion kinyoklion requested a review from a team as a code owner July 29, 2024 22:49
tanderson-ld
tanderson-ld reviewed Jul 30, 2024
View reviewed changes
@kinyoklion kinyoklion requested a review from tanderson-ld July 30, 2024 15:57
@kinyoklion kinyoklion merged commit fd0d678 into feat/client-connection-handling-rework Jul 30, 2024
@kinyoklion kinyoklion deleted the rlamb/sc-251453/refactor-application-state-management branch July 30, 2024 19:06
kinyoklion added a commit that referenced this pull request Jul 31, 2024
@kinyoklion
feat: Refactor application state handling. (#523)
bce98e9
kinyoklion added a commit that referenced this pull request Aug 1, 2024
@kinyoklion
feat: Refactor application state handling. (#523)
f5b81e6
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Merged
kinyoklion pushed a commit that referenced this pull request Aug 13, 2024
@github-actions @tanderson-ld
chore: release main (#534)
5f89aee 
🤖 I have created a release *beep* *boop*
---


<details><summary>akamai-edgeworker-sdk-common: 1.1.12</summary>

##
[1.1.12](akamai-edgeworker-sdk-common-v1.1.11...akamai-edgeworker-sdk-common-v1.1.12)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from ^2.4.4 to ^2.4.5
</details>

<details><summary>akamai-server-base-sdk: 2.1.12</summary>

##
[2.1.12](akamai-server-base-sdk-v2.1.11...akamai-server-base-sdk-v2.1.12)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.11 to
^1.1.12
    * @launchdarkly/js-server-sdk-common bumped from ^2.4.4 to ^2.4.5
</details>

<details><summary>akamai-server-edgekv-sdk: 1.1.12</summary>

##
[1.1.12](akamai-server-edgekv-sdk-v1.1.11...akamai-server-edgekv-sdk-v1.1.12)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.11 to
^1.1.12
    * @launchdarkly/js-server-sdk-common bumped from ^2.4.4 to ^2.4.5
</details>

<details><summary>cloudflare-server-sdk: 2.5.10</summary>

##
[2.5.10](cloudflare-server-sdk-v2.5.9...cloudflare-server-sdk-v2.5.10)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.3.5 to 2.3.6
</details>

<details><summary>js-client-sdk-common: 1.3.0</summary>

##
[1.3.0](js-client-sdk-common-v1.2.0...js-client-sdk-common-v1.3.0)
(2024-08-12)


### Features

* Add connection mananger.
([#522](#522))
([5bf8b16](5bf8b16))
* Implement polling support.
([#524](#524))
([a99048e](a99048e))
* Refactor application state handling.
([#523](#523))
([f5b81e6](f5b81e6))
* refactors the implementation of context caching. You can now s…
([#531](#531))
([8ab2ee4](8ab2ee4))


### Bug Fixes

* Fix field visibility.
([#530](#530))
([21fb18b](21fb18b))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-sdk-common bumped from 2.5.0 to 2.6.0
</details>

<details><summary>js-sdk-common: 2.6.0</summary>

##
[2.6.0](js-sdk-common-v2.5.0...js-sdk-common-v2.6.0)
(2024-08-12)


### Features

* refactors the implementation of context caching. You can now s…
([#531](#531))
([8ab2ee4](8ab2ee4))
</details>

<details><summary>js-server-sdk-common: 2.4.5</summary>

##
[2.4.5](js-server-sdk-common-v2.4.4...js-server-sdk-common-v2.4.5)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-sdk-common bumped from 2.5.0 to 2.6.0
</details>

<details><summary>js-server-sdk-common-edge: 2.3.6</summary>

##
[2.3.6](js-server-sdk-common-edge-v2.3.5...js-server-sdk-common-edge-v2.3.6)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.4.4 to 2.4.5
</details>

<details><summary>node-server-sdk: 9.5.1</summary>

##
[9.5.1](node-server-sdk-v9.5.0...node-server-sdk-v9.5.1)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.4.4 to 2.4.5
</details>

<details><summary>node-server-sdk-dynamodb: 6.1.18</summary>

##
[6.1.18](node-server-sdk-dynamodb-v6.1.17...node-server-sdk-dynamodb-v6.1.18)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.5.0 to 9.5.1
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.1
</details>

<details><summary>node-server-sdk-otel: 1.0.10</summary>

##
[1.0.10](node-server-sdk-otel-v1.0.9...node-server-sdk-otel-v1.0.10)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.5.0 to 9.5.1
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.1
</details>

<details><summary>node-server-sdk-redis: 4.1.18</summary>

##
[4.1.18](node-server-sdk-redis-v4.1.17...node-server-sdk-redis-v4.1.18)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.5.0 to 9.5.1
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.1
</details>

<details><summary>react-native-client-sdk: 10.4.0</summary>

##
[10.4.0](react-native-client-sdk-v10.3.1...react-native-client-sdk-v10.4.0)
(2024-08-12)


### Features

* Add configuration validation for ReactNative specific configuration.
([#532](#532))
([c1490e2](c1490e2))
* Add connection mananger.
([#522](#522))
([5bf8b16](5bf8b16))
* Implement polling support.
([#524](#524))
([a99048e](a99048e))
* Refactor application state handling.
([#523](#523))
([f5b81e6](f5b81e6))


### Bug Fixes

* Fix field visibility.
([#530](#530))
([21fb18b](21fb18b))
* Handle non-status code errors for streaming connection.
([#533](#533))
([fc4645e](fc4645e))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.2.0 to 1.3.0
</details>

<details><summary>vercel-server-sdk: 1.3.13</summary>

##
[1.3.13](vercel-server-sdk-v1.3.12...vercel-server-sdk-v1.3.13)
(2024-08-12)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.3.5 to 2.3.6
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Todd Anderson <127344469+tanderson-ld@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanderson-ld tanderson-ld tanderson-ld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kinyoklion @tanderson-ld