feat: Implement polling support. #524

kinyoklion · 2024-07-30T19:23:01Z

No description provided.

…51453/refactor-application-state-management

…into rlamb/sc-249240/implement-polling-support

…49240/implement-polling-support

kinyoklion · 2024-07-30T19:24:26Z

packages/shared/sdk-client/src/LDClientImpl.storage.test.ts

  });

 // Common setup code for all tests
-// 1. Sets up streamer


Replaced all streamer with either updateProcessor or streaming.

kinyoklion · 2024-07-30T19:25:20Z

packages/shared/sdk-client/src/LDClientImpl.ts

        if (this.context) {
-          // identify will start streamer
+          // identify will start the update processor
          return this.identify(this.context, { timeout: this.identifyTimeout });


I think this isn't the correct way to do this long-term. We don't need the identify events, for instance, and are probably doing more work than required.

kinyoklion · 2024-07-31T15:49:00Z

packages/shared/sdk-client/src/LDClientImpl.ts

+      pollingPath = `${pollingPath}?withReasons=true`;
+    }
+    this.updateProcessor = new PollingProcessor(
+      this.sdkKey,


Streaming takes a "ClientContext", but providing the individual items allows better encapsulation and also mocking without needing to mock as many components.

kinyoklion · 2024-07-31T15:49:38Z

packages/shared/sdk-client/src/configuration/Configuration.ts

  public readonly privateAttributes: string[] = [];

  public readonly initialConnectionMode: ConnectionMode = 'streaming';
-  public connectionMode: ConnectionMode;


Runtime state is part of the client now, not part of the configuration.

kinyoklion · 2024-07-31T16:33:27Z

packages/shared/sdk-client/src/polling/Requestor.ts

+}
+
+/**
+ * Note: The requestor is implemented independently from polling such that it can be used to


In the browser version of JS we should maintain something close to the existing behavior, and we can use this to do that. Current js-client-sdk will make a single request first. If someone listens to changes, or specifically requests streaming, then it will stream.

We may make the requestor in the client, but for now I am putting it in the polling implementation.

The spelling Requestor is for consistency even though requester would be more common in american english.

🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 1.1.12</summary> ## [1.1.12](akamai-edgeworker-sdk-common-v1.1.11...akamai-edgeworker-sdk-common-v1.1.12) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.4.4 to ^2.4.5 </details> <details><summary>akamai-server-base-sdk: 2.1.12</summary> ## [2.1.12](akamai-server-base-sdk-v2.1.11...akamai-server-base-sdk-v2.1.12) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.11 to ^1.1.12 * @launchdarkly/js-server-sdk-common bumped from ^2.4.4 to ^2.4.5 </details> <details><summary>akamai-server-edgekv-sdk: 1.1.12</summary> ## [1.1.12](akamai-server-edgekv-sdk-v1.1.11...akamai-server-edgekv-sdk-v1.1.12) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.1.11 to ^1.1.12 * @launchdarkly/js-server-sdk-common bumped from ^2.4.4 to ^2.4.5 </details> <details><summary>cloudflare-server-sdk: 2.5.10</summary> ## [2.5.10](cloudflare-server-sdk-v2.5.9...cloudflare-server-sdk-v2.5.10) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.3.5 to 2.3.6 </details> <details><summary>js-client-sdk-common: 1.3.0</summary> ## [1.3.0](js-client-sdk-common-v1.2.0...js-client-sdk-common-v1.3.0) (2024-08-12) ### Features * Add connection mananger. ([#522](#522)) ([5bf8b16](5bf8b16)) * Implement polling support. ([#524](#524)) ([a99048e](a99048e)) * Refactor application state handling. ([#523](#523)) ([f5b81e6](f5b81e6)) * refactors the implementation of context caching. You can now s… ([#531](#531)) ([8ab2ee4](8ab2ee4)) ### Bug Fixes * Fix field visibility. ([#530](#530)) ([21fb18b](21fb18b)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.5.0 to 2.6.0 </details> <details><summary>js-sdk-common: 2.6.0</summary> ## [2.6.0](js-sdk-common-v2.5.0...js-sdk-common-v2.6.0) (2024-08-12) ### Features * refactors the implementation of context caching. You can now s… ([#531](#531)) ([8ab2ee4](8ab2ee4)) </details> <details><summary>js-server-sdk-common: 2.4.5</summary> ## [2.4.5](js-server-sdk-common-v2.4.4...js-server-sdk-common-v2.4.5) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.5.0 to 2.6.0 </details> <details><summary>js-server-sdk-common-edge: 2.3.6</summary> ## [2.3.6](js-server-sdk-common-edge-v2.3.5...js-server-sdk-common-edge-v2.3.6) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.4.4 to 2.4.5 </details> <details><summary>node-server-sdk: 9.5.1</summary> ## [9.5.1](node-server-sdk-v9.5.0...node-server-sdk-v9.5.1) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.4.4 to 2.4.5 </details> <details><summary>node-server-sdk-dynamodb: 6.1.18</summary> ## [6.1.18](node-server-sdk-dynamodb-v6.1.17...node-server-sdk-dynamodb-v6.1.18) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.5.0 to 9.5.1 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.1 </details> <details><summary>node-server-sdk-otel: 1.0.10</summary> ## [1.0.10](node-server-sdk-otel-v1.0.9...node-server-sdk-otel-v1.0.10) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.5.0 to 9.5.1 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.1 </details> <details><summary>node-server-sdk-redis: 4.1.18</summary> ## [4.1.18](node-server-sdk-redis-v4.1.17...node-server-sdk-redis-v4.1.18) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.5.0 to 9.5.1 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.5.1 </details> <details><summary>react-native-client-sdk: 10.4.0</summary> ## [10.4.0](react-native-client-sdk-v10.3.1...react-native-client-sdk-v10.4.0) (2024-08-12) ### Features * Add configuration validation for ReactNative specific configuration. ([#532](#532)) ([c1490e2](c1490e2)) * Add connection mananger. ([#522](#522)) ([5bf8b16](5bf8b16)) * Implement polling support. ([#524](#524)) ([a99048e](a99048e)) * Refactor application state handling. ([#523](#523)) ([f5b81e6](f5b81e6)) ### Bug Fixes * Fix field visibility. ([#530](#530)) ([21fb18b](21fb18b)) * Handle non-status code errors for streaming connection. ([#533](#533)) ([fc4645e](fc4645e)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.2.0 to 1.3.0 </details> <details><summary>vercel-server-sdk: 1.3.13</summary> ## [1.3.13](vercel-server-sdk-v1.3.12...vercel-server-sdk-v1.3.13) (2024-08-12) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.3.5 to 2.3.6 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Anderson <127344469+tanderson-ld@users.noreply.github.com>

kinyoklion added 16 commits July 25, 2024 16:12

First draft of polling implementation.

33ac43a

Correct streaming URL.

ec7883c

feat: Add connection mananger.

d5c0132

Implement tests.

2aa885f

Start implementation of the state detector.

2c896b9

wip

3dd2808

Make enums backed by string values for easier logging.

e8e44d3

Merge branch 'rlamb/sc-251453/add-connection-manager' into rlamb/sc-2…

f22eb37

…51453/refactor-application-state-management

feat: Refactor application state handling.

b54463a

Merge branch 'feat/client-connection-handling-rework' into rlamb/sc-2…

3de892d

…51453/refactor-application-state-management

PR Cleanup

359d71d

Add some blank lines.

b68e4dd

Add not implemented comment.

7cf3adf

PR feedback

9559afd

Merge branch 'rlamb/sc-251453/refactor-application-state-management' …

11af6b8

…into rlamb/sc-249240/implement-polling-support

Merge branch 'feat/client-connection-handling-rework' into rlamb/sc-2…

56144a6

…49240/implement-polling-support

kinyoklion commented Jul 30, 2024

View reviewed changes

kinyoklion added 4 commits July 30, 2024 12:26

Make debug output type for connection mode more consistent.

3e159f5

Fix merge marker.

efe76ea

Implement polling tests.

53c0afb

Lint

08c4a64

kinyoklion commented Jul 31, 2024

View reviewed changes

kinyoklion added 2 commits July 31, 2024 09:30

Refactoring.

b6c26cb

Address todo

fb6e265

kinyoklion commented Jul 31, 2024

View reviewed changes

kinyoklion added 2 commits July 31, 2024 09:35

Linting

9b9d8a7

More lint.

a515049

kinyoklion marked this pull request as ready for review July 31, 2024 16:40

kinyoklion requested a review from a team as a code owner July 31, 2024 16:40

Add some internal tags.

20ba4ff

tanderson-ld approved these changes Jul 31, 2024

View reviewed changes

kinyoklion merged commit f861078 into feat/client-connection-handling-rework Jul 31, 2024

kinyoklion deleted the rlamb/sc-249240/implement-polling-support branch July 31, 2024 20:32

kinyoklion added a commit that referenced this pull request Jul 31, 2024

feat: Implement polling support. (#524)

0b3491e

kinyoklion added a commit that referenced this pull request Aug 1, 2024

feat: Implement polling support. (#524)

a99048e

github-actions bot mentioned this pull request Aug 1, 2024

chore: release main #534

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Implement polling support. #524

feat: Implement polling support. #524

Uh oh!

kinyoklion commented Jul 30, 2024

Uh oh!

kinyoklion Jul 30, 2024

Uh oh!

kinyoklion Jul 30, 2024

Uh oh!

kinyoklion Jul 31, 2024

Uh oh!

kinyoklion Jul 31, 2024

Uh oh!

kinyoklion Jul 31, 2024

Uh oh!

kinyoklion Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Implement polling support. #524

feat: Implement polling support. #524

Uh oh!

Conversation

kinyoklion commented Jul 30, 2024

Uh oh!

kinyoklion Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

kinyoklion Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

kinyoklion Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

kinyoklion Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

kinyoklion Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

kinyoklion Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants