feat: Remove mock fetch from mocks. #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
approved these changes
Jul 31, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk-common: 1.2.0</summary> ## [1.2.0](js-client-sdk-common-v1.1.5...js-client-sdk-common-v1.2.0) (2024-07-31) ### Features * Remove mock fetch from mocks. ([#525](#525)) ([fa8e579](fa8e579)) </details> <details><summary>react-native-client-sdk: 10.3.1</summary> ## [10.3.1](react-native-client-sdk-v10.3.0...react-native-client-sdk-v10.3.1) (2024-07-31) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.1.5 to 1.2.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not used and had hidden global state which would have caused confusion if used.
I also removed fetchFlags because it was unused and will be replaced with a used version in from the polling feature branch.