feat: Change the typing for the LDAIConfig. #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Nov 14, 2024
| model: aiConfig.config.model?.modelId || 'gpt-4', | ||
| messages: aiConfig.prompt || [], | ||
| model: aiConfig.model?.modelId || 'gpt-4', | ||
| temperature: aiConfig.model?.temperature ?? 0.5, |
There was a problem hiding this comment.
Added temperature and maxTokens usage to the bedrock and OpenAI examples.
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
|
I have not handled the interpolation failure yet. |
keelerm84
approved these changes
Nov 15, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>server-sdk-ai: 0.3.0</summary> ## [0.3.0](server-sdk-ai-v0.2.1...server-sdk-ai-v0.3.0) (2024-11-15) ### Features * Change the typing for the LDAIConfig. ([#688](#688)) ([1f3f54a](1f3f54a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten the AI config moving model/prompt to the top level.
Change the LDAIDefaults to match this change.
Remove the generation config type which was the type of the
configfield.Add temperature and maxTokens as optionals to the model config.
Make
modelIdrequired.Updated the examples to include temperature and maxTokens.
SDK-912