feat!: Only support identify with result.

[kinyoklion]

Originally the SDK API had an identify method which didn't return any result. We added an identifyResult which is a safer API.

We have decided that we shouldn't support the less-safe API and instead should have a single identify method. So the regular identify method will now have the behavior of identifyResult.

This moves the browser client to use a PIMPL implementation to decouple its interface of the inheritance hierarchy. Which allows for identify to have a completely different signature than the base implementation. It also allows us to retain identify in RN until we are ready to do a major version.

For the PIMPL implementation I decided to use a factory instead of a class. So tests needed updated to use that factory.

I also re-organized plugin registration so the better encapsulate PIMPL implementation would be passed to register.

The "compat" adapter needed to be updated to use the new API. For now it supports using the old interface, but we may want to consider removing it if we determine it isn't safe.

---

Note

Replaces the BrowserClient class with a makeClient factory using a PIMPL impl and changes identify to return LDIdentifyResult (replacing identifyResult); updates plugin registration, compat, initialization, and tests.

• API
  • identify now returns LDIdentifyResult (with statuses like completed/shed/timeout/error) and accepts browser-specific options; identifyResult is removed from the public interface.
  • Introduce factory makeClient wrapping an internal BrowserClientImpl (PIMPL); initialize now uses makeClient.
  • LDClient type updated to expose the new identify signature and omit the old one.
• Plugins
  • Refactor plugin registration to register against the public PIMPL client; hook retrieval unchanged; environment metadata still forwarded.
• Compat
  • LDClientCompatImpl updated to use makeClient and new identify result handling; passes sheddable: false, propagates bootstrap/hash, and maps failures/timeouts.
• Tests
  • Migrate tests to makeClient; adjust expectations for identify return values and shedding behavior; verify plugin registration and environment metadata.

^{Written by Cursor Bugbot for commit 4df7885. This will update automatically on new commits. Configure here.}

[github-actions]

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 169118 bytes
Compressed size limit: 200000
Uncompressed size: 789399 bytes

[github-actions]

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 24988 bytes
Compressed size limit: 26000
Uncompressed size: 122411 bytes

[github-actions]

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 17636 bytes
Compressed size limit: 20000
Uncompressed size: 90259 bytes

[github-actions]

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 21981 bytes
Compressed size limit: 25000
Uncompressed size: 75580 bytes

[kinyoklion]

bugbot review