[sc-154361] #1 Implement target evaluation and 'OFF' evaluation. #12
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| import { Context, LDContext } from '@launchdarkly/js-sdk-common'; | ||
|
Member
Author
There was a problem hiding this comment. Currently there are very limited tests for just the couple things the evaluator supports. |
||
| import { BigSegmentStoreMembership } from '../../src/api/interfaces'; | ||
| import { Flag } from '../../src/evaluation/data/Flag'; | ||
| import { Segment } from '../../src/evaluation/data/Segment'; | ||
| import EvalResult from '../../src/evaluation/EvalResult'; | ||
| import Evaluator from '../../src/evaluation/Evaluator'; | ||
| import { Queries } from '../../src/evaluation/Queries'; | ||
| import Reasons from '../../src/evaluation/Reasons'; | ||
|
|
||
| const offBaseFlag = { | ||
| key: 'feature0', | ||
| version: 1, | ||
| on: false, | ||
| fallthrough: { variation: 1 }, | ||
| variations: [ | ||
| 'zero', | ||
| 'one', | ||
| 'two', | ||
| ], | ||
| }; | ||
|
|
||
| const noQueries: Queries = { | ||
| getFlag(): Promise<Flag | null> { | ||
| throw new Error('Function not implemented.'); | ||
| }, | ||
| getSegment(): Promise<Segment | null> { | ||
| throw new Error('Function not implemented.'); | ||
| }, | ||
| getBigSegmentsMembership(): Promise<BigSegmentStoreMembership | null> { | ||
| throw new Error('Function not implemented.'); | ||
| }, | ||
| }; | ||
|
|
||
| describe.each<[Flag, LDContext, EvalResult | undefined]>([ | ||
| [{ | ||
| ...offBaseFlag, | ||
| }, { key: 'user-key' }, EvalResult.ForSuccess(null, Reasons.Off, undefined)], | ||
| [{ | ||
| ...offBaseFlag, offVariation: 2, | ||
| }, { key: 'user-key' }, EvalResult.ForSuccess('two', Reasons.Off, 2)], | ||
| ])('Given off flags and an evaluator', (flag, context, expected) => { | ||
| const evaluator = new Evaluator(noQueries); | ||
|
|
||
| // @ts-ignore | ||
| it(`produces the expected evaluation result for context: ${context.key} ${context.kind} targets: ${flag.targets?.map((t) => `${t.values}, ${t.variation}`)} context targets: ${flag.contextTargets?.map((t) => `${t.contextKind}: ${t.values}, ${t.variation}`)}`, async () => { | ||
| const result = await evaluator.evaluate(flag, Context.FromLDContext(context)!); | ||
| expect(result?.isError).toEqual(expected?.isError); | ||
|
Contributor
There was a problem hiding this comment. Similar to my earlier comment, I think I would prefer a more specific failure here if |
||
| expect(result?.detail).toStrictEqual(expected?.detail); | ||
| expect(result?.message).toEqual(expected?.message); | ||
| }); | ||
| }); | ||
|
|
||
| const targetBaseFlag = { | ||
| key: 'feature0', | ||
| version: 1, | ||
| on: true, | ||
| fallthrough: { variation: 1 }, | ||
| variations: [ | ||
| 'zero', | ||
| 'one', | ||
| 'two', | ||
| ], | ||
| }; | ||
|
|
||
| describe.each<[Flag, LDContext, EvalResult | undefined]>([ | ||
| [{ | ||
| ...targetBaseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }], | ||
| }, { key: 'user-key' }, EvalResult.ForSuccess('zero', Reasons.TargetMatch, 0)], | ||
| [{ | ||
| ...targetBaseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| }, { key: 'user-key2' }, EvalResult.ForSuccess('two', Reasons.TargetMatch, 2)], | ||
| [{ | ||
| ...targetBaseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| contextTargets: [{ | ||
| values: [], | ||
| variation: 2, | ||
| }], | ||
| }, { key: 'user-key2' }, EvalResult.ForSuccess('two', Reasons.TargetMatch, 2)], | ||
| [{ | ||
| ...targetBaseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| contextTargets: [{ | ||
| contextKind: 'org', | ||
| values: ['org-key'], | ||
| variation: 1, | ||
| }], | ||
| }, { kind: 'org', key: 'org-key' }, EvalResult.ForSuccess('one', Reasons.TargetMatch, 1)], | ||
| ])('given flag configurations with different targets that match', (flag, context, expected) => { | ||
| const evaluator = new Evaluator(noQueries); | ||
| // @ts-ignore | ||
| it(`produces the expected evaluation result for context: ${context.key} ${context.kind} targets: ${flag.targets?.map((t) => `${t.values}, ${t.variation}`)} context targets: ${flag.contextTargets?.map((t) => `${t.contextKind}: ${t.values}, ${t.variation}`)}`, async () => { | ||
| const result = await evaluator.evaluate(flag, Context.FromLDContext(context)!); | ||
| expect(result?.isError).toEqual(expected?.isError); | ||
| expect(result?.detail).toStrictEqual(expected?.detail); | ||
| expect(result?.message).toEqual(expected?.message); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| import { Context, LDContext } from '@launchdarkly/js-sdk-common'; | ||
| import { Flag } from '../../src/evaluation/data/Flag'; | ||
| import EvalResult from '../../src/evaluation/EvalResult'; | ||
| import evalTargets from '../../src/evaluation/evalTargets'; | ||
| import Reasons from '../../src/evaluation/Reasons'; | ||
|
|
||
| const baseFlag = { | ||
| key: 'feature0', | ||
| version: 1, | ||
| on: true, | ||
| fallthrough: { variation: 1 }, | ||
| variations: [ | ||
| 'zero', | ||
| 'one', | ||
| 'two', | ||
| ], | ||
| }; | ||
|
|
||
| describe.each<[Flag, LDContext, EvalResult | undefined]>([ | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }], | ||
| }, { key: 'user-key' }, EvalResult.ForSuccess('zero', Reasons.TargetMatch, 0)], | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }], | ||
| }, { key: 'different-key' }, undefined], | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| }, { key: 'user-key2' }, EvalResult.ForSuccess('two', Reasons.TargetMatch, 2)], | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }], | ||
| }, { key: 'different-key' }, undefined], | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| contextTargets: [{ | ||
| values: [], | ||
| variation: 2, | ||
| }], | ||
| }, { key: 'user-key2' }, EvalResult.ForSuccess('two', Reasons.TargetMatch, 2)], | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| contextTargets: [{ | ||
| values: [], | ||
| variation: 2, | ||
| }], | ||
| }, { kind: 'org', key: 'user-key2' }, undefined], | ||
| [{ | ||
| ...baseFlag, | ||
| targets: [{ | ||
| values: ['user-key'], | ||
| variation: 0, | ||
| }, | ||
| { | ||
| values: ['user-key2'], | ||
| variation: 2, | ||
| }, | ||
| ], | ||
| contextTargets: [{ | ||
| contextKind: 'org', | ||
| values: ['org-key'], | ||
| variation: 1, | ||
| }], | ||
| }, { kind: 'org', key: 'org-key' }, EvalResult.ForSuccess('one', Reasons.TargetMatch, 1)], | ||
| [{ | ||
| ...baseFlag, | ||
| contextTargets: [{ | ||
| values: ['org-key'], | ||
| variation: 1, | ||
| }], | ||
| }, { key: 'user-key' }, undefined], | ||
| [{ | ||
| ...baseFlag, | ||
| }, { key: 'user-key' }, undefined], | ||
| ])('given flag configurations with different targets', (flag, context, expected) => { | ||
| // @ts-ignore | ||
| it(`produces the expected evaluation result for context: ${context.key} ${context.kind} targets: ${flag.targets?.map((t) => `${t.values}, ${t.variation}`)} context targets: ${flag.contextTargets?.map((t) => `${t.contextKind}: ${t.values}, ${t.variation}`)}`, () => { | ||
| const result = evalTargets(flag, Context.FromLDContext(context)!); | ||
| expect(result?.isError).toEqual(expected?.isError); | ||
| expect(result?.detail).toStrictEqual(expected?.detail); | ||
| expect(result?.message).toEqual(expected?.message); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the order of these params to allow for the kind to be optional and simplify evaluation logic.