Eval #1: Add bucketing and common bucketing tests. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #154361: Implement evaluation.. |
kinyoklion
changed the title
kinyoklion
commented
Jun 1, 2022
| @@ -1,3 +1,9 @@ | |||
| import Context from './Context'; | |||
Member
Author
There was a problem hiding this comment.
Now that I am using the context I need to export it.
kinyoklion
commented
Jun 1, 2022
| key: 'new-feature', | ||
| version: 1, | ||
| }; | ||
| await featureStore.upsert({namespace: 'potato'}, newPotato); |
Member
Author
There was a problem hiding this comment.
Linty mclinterson changed this.
kinyoklion
changed the title
keelerm84
approved these changes
Jun 2, 2022
Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bucketing, but because bucketing depends on hashing, which is a platform dependency, the tests only validate we get the expected hashing input.
When more of the algorithm is implemented, then more tests will be added at the node platform level.