Merged
Conversation
|
This pull request has been linked to Shortcut Story #236003: create stubbed out screen to auto-create project, environment, flag. |
sunnyguduru
commented
Mar 12, 2024
sunnyguduru
commented
Mar 12, 2024
sunnyguduru
commented
Mar 12, 2024
dbolson
reviewed
Mar 12, 2024
* ci: add publish action to release-please workflow * feat: add required go-versions * remove unnecessary setup steps, go-versions
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: uncomment conditional for release-ldcli
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: Update release-please.yml to dry-run: false This reverts commit ea3c089.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
`ldcli projects list` returns list of projects in JSON
sunnyguduru
changed the title
sunnyguduru
commented
Mar 13, 2024
| } | ||
|
|
||
| return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep-1].View(), m.currStep, len(m.steps)) | ||
| return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps)) |
Author
There was a problem hiding this comment.
Got a little confused here. But basically we're rendering the current step's view. While showing what step we're on in the header out of the total number of steps.
Was able to use currStep instead of currStep-1 since I got rid of the initial step.
| m.currStep += 1 | ||
| case projectsStep: | ||
| projModel, _ := m.steps[m.currStep-1].Update(msg) | ||
| projModel, _ := m.steps[projectsStep].Update(msg) |
Author
There was a problem hiding this comment.
I think it makes sense to just directly use projectsStep here. Since the case is already ensuring we're on projectsStep. Same for the other cases
dbolson
approved these changes
Mar 13, 2024
| func NewAutoCreate() autoCreateModel { | ||
| choices := []choice{ | ||
| { | ||
| Key: "yes", |
Contributor
There was a problem hiding this comment.
We probably only need the name here and the check later on could be for "Yes" instead of "yes".
| @@ -0,0 +1,116 @@ | |||
| package setup | |||
Contributor
There was a problem hiding this comment.
Can you rename the file auto_create.go to be more idiomatic?
sunnyguduru
deleted the
sunny/sc-236003/create-stubbed-out-screen-to-auto-create
branch
This was referenced Mar 13, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto Create is now the initial step.
The steps are the following:
Screenshot:
Video:
https://share.cleanshot.com/bdhRcswf