feat: add new input model, use in projects step#30
Merged
k3llymariee merged 8 commits intomainfrom Mar 18, 2024
Merged
Conversation
|
This pull request has been linked to Shortcut Story #235547: Create stubbed out setup command to act as a prototype. |
sunnyguduru
approved these changes
Mar 18, 2024
k3llymariee
commented
Mar 18, 2024
Comment on lines
-86
to
-97
| // we need to cast this to get the data out of it, but maybe we can create our own interface with | ||
| // common values such as Choice() and Err() so we don't have to cast | ||
| p, ok := projModel.(projectModel) | ||
| if ok { | ||
| if p.err != nil { | ||
| m.err = p.err | ||
| return m, nil | ||
| } | ||
| } | ||
| // update projModel with the fetched projects | ||
| m.steps[projectsStep] = projModel | ||
| // go to the next step |
Contributor
Author
There was a problem hiding this comment.
i don't think we actually needed to do this casting here
Comment on lines
+95
to
+96
| // we need to cast this to get the data out of it, but maybe we can create our own interface with | ||
| // common values such as Choice() and Err() so we don't have to cast |
Contributor
Author
There was a problem hiding this comment.
but we do need to do it here so i moved that comment down
This was referenced Mar 18, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new re-usable input model and adds it to the projects step.
ld-cli-set-new-project.mov