Conversation
added 2 commits
March 20, 2024 11:00
|
This pull request has been linked to Shortcut Story #237279: show sample code in setup wizard. |
dbolson
commented
Mar 20, 2024
| return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps)) | ||
| } | ||
|
|
||
| func (m WizardModel) renderMarkdown() string { |
Contributor
Author
There was a problem hiding this comment.
There's a good chance we could simplify this. We could also update this to get the markdown from github directly instead of keeping the files locally.
k3llymariee
approved these changes
Mar 20, 2024
Contributor
k3llymariee
left a comment
k3llymariee
left a comment
There was a problem hiding this comment.
👏👏👏
just one small change show we can update the flag name in the instructions file
| ```go | ||
| const sdkKey = "1234567890abcdef" | ||
|
|
||
| const featureFlagKey = "my-flag" |
Contributor
There was a problem hiding this comment.
could we change this to my-flag-key so the strings.ReplaceAll works for this file also (below also)
This was referenced Mar 20, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render SDK instructions as markdown.
before:
after: