feat: create flag as first step in wizard#42
Merged
k3llymariee merged 4 commits intomainfrom Mar 20, 2024
Merged
Conversation
|
This pull request has been linked to Shortcut Story #237273: create feature flag in setup wizard. |
dbolson
approved these changes
Mar 20, 2024
Contributor
dbolson
left a comment
dbolson
left a comment
There was a problem hiding this comment.
I wonder if we disable going back since we'll create the flag when the user enters the name, so going back would create a second flag. I'll add a ticket to look into that so we don't forget, but the current behavior seems fine for now.
k3llymariee
deleted the
kelly/sc-237273/create-feature-flag-as-first-step-in-setup-wizard
branch
This was referenced Mar 20, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the wizard prototype to mimic the 0->1 quickstart where we only prompt the user to create a new flag (i.e. assuming they only have the default project on their account). Removes the steps where we list existing projs/envs/flags to choose from.
One thing I'd like to call out: how do we want to handle going back from the SDK step? Right now the last entered value will remain in place (as shown in the recording) but let me know if we want to try to get rid of that? Or not?
new-flag-step.mov