Skip to content

fix: Retry when there are 429s on flag metadata fetches#446

Merged
mike-zorn merged 1 commit intomainfrom
FUN-252/mrz/rate-limits-not-respected-by-launch-devly-flag-fetches
Oct 7, 2024
Merged

fix: Retry when there are 429s on flag metadata fetches#446
mike-zorn merged 1 commit intomainfrom
FUN-252/mrz/rate-limits-not-respected-by-launch-devly-flag-fetches

Conversation

@mike-zorn
Copy link

This adds retry-on-429 support to the dev server when it syncs data from the flags API. It uses the X-RateLimit-Reset to determine when to retry the request. This also moves the api utilities into an internal package instead of inline with the api adapter.

@mike-zorn mike-zorn requested a review from cdelst October 7, 2024 18:09
Copy link
Contributor

@cdelst cdelst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool beans

@mike-zorn mike-zorn changed the title Retry when there are 429s on flag metadata fetches fix: Retry when there are 429s on flag metadata fetches Oct 7, 2024
@mike-zorn mike-zorn merged commit e5da2e9 into main Oct 7, 2024
@mike-zorn mike-zorn deleted the FUN-252/mrz/rate-limits-not-respected-by-launch-devly-flag-fetches branch October 7, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants