Conversation
|
This pull request has been linked to Shortcut Story #237425: Make styling consistent across setup steps. |
dbolson
force-pushed
the
sc-237425/consistent-styles
branch
from
cf719ce to
9848397
Compare
dbolson
commented
Mar 21, 2024
|
|
||
| type flagModel struct { | ||
| input string | ||
| err error |
| return wordwrap.String( | ||
| fmt.Sprintf( | ||
| "Set up your application. Here are the steps to incorporate the LaunchDarkly %s SDK into your code. \n\n%s", | ||
| "Set up your application. Here are the steps to incorporate the LaunchDarkly %s SDK into your code.\n%s", |
Contributor
Author
There was a problem hiding this comment.
Removed an extra newline.
|
|
||
| type sdkModel struct { | ||
| choice sdk | ||
| instructions string |
| l.Title = "Select your SDK." | ||
| l.Title = "Select your SDK\n" | ||
| // reset title styles | ||
| l.Styles.Title = lipgloss.NewStyle() |
Contributor
Author
There was a problem hiding this comment.
These get default styles set on then from list.New, so we need to remove them.
sunnyguduru
approved these changes
Mar 21, 2024
dbolson
commented
Mar 21, 2024
| if m.enabled { | ||
| bgColor = "#3d9c51" | ||
| furtherInstructions = "\n\nCheck your [browser|application logs] to see the change!" | ||
| furtherInstructions = "\n\nCheck your [browser|application logs] to see the change." |
Contributor
Author
There was a problem hiding this comment.
Lowered the volume on this because there's an exclamation above.
| } | ||
|
|
||
| func (m sdkInstructionModel) View() string { | ||
| style := lipgloss.NewStyle().Border(lipgloss.NormalBorder()) |
Contributor
Author
There was a problem hiding this comment.
Added a border around the instructions like in the screenshots.
| } | ||
|
|
||
| return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps)) | ||
| return fmt.Sprintf("\nStep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps)) |
k3llymariee
approved these changes
Mar 21, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the styling consistent across each setup step. Specifically, the title spacing and removing its bg color.
