feat: use tab to toggle, add final step#50
Merged
k3llymariee merged 10 commits intomainfrom Mar 21, 2024
Merged
Conversation
|
This pull request has been linked to Shortcut Story #237281: show toggle flag in setup wizard. |
added 2 commits
March 21, 2024 10:48
k3llymariee
commented
Mar 21, 2024
| case flagToggleStep: | ||
| updatedModel, _ := m.steps[flagToggleStep].Update(msg) | ||
| m.steps[flagToggleStep] = updatedModel | ||
| m.currStep += 1 |
Contributor
Author
There was a problem hiding this comment.
increment here on enter so we can see the final text
| m.steps[flagToggleStep] = updatedModel | ||
| m.currStep += 1 | ||
| default: | ||
| return m, tea.Quit |
Contributor
Author
There was a problem hiding this comment.
if we're here that means we're done! will prevent out of index errors
dbolson
approved these changes
Mar 21, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates our flag toggle step to toggle on
tabrather thanenter. Also adds a final congratulatory screen and exits on completion.pr50.mov