Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.
This repository was archived by the owner on May 30, 2024. It is now read-only.

Client should emit errors rather than logging #55

@mbrevoort

Description

@mbrevoort

When there are errors the client is spamming my logs with multiline stack trace logs like this:

error: [LaunchDarkly] Error: Unexpected error:
    at /Users/mike/dev/missions/missions/node_modules/ldclient-node/index.js:71:19
    at EventSource.es.onerror (/Users/mike/dev/missions/missions/node_modules/ldclient-node/streaming.js:19:7)
    at emitOne (events.js:96:13)
    at EventSource.emit (events.js:188:7)
    at _emit (/Users/mike/dev/missions/missions/node_modules/ldclient-node/eventsource.js:182:17)
    at ClientRequest.onConnectionClosed (/Users/mike/dev/missions/missions/node_modules/ldclient-node/eventsource.js:43:5)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at TLSSocket.socketErrorListener (_http_client.js:309:9)
    at emitOne (events.js:96:13)

This is a problem is you are using a structured logger, for example a JSON line delimited format. Instead should emit errors instead. This would be trivial since the LD client is already an EventEmitter.

This would allow the consumer to control how logs are output. For example:

  ldClient.on('error', err => {
    let message = err
    if (err.stack) {
      let firstStackLine = (err.stack.split('\n')[1] || '').trim()
      message = `LaunchDarkly error: ${err} ${firstStackLine}`
    }
    logger.error(message)
  })

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions