Skip to content

Update for node SDK 8 release. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update for node SDK 8 release. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07b6989
Update for node SDK 8 release.
kinyoklion Jun 14, 2023
420f287
Update tests for changes to OF SDK.
kinyoklion Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ This version of the LaunchDarkly OpenFeature provider is compatible with Node.js

```
npm install @openfeature/js-sdk
npm install launchdarkly-node-server-sdk
npm install @launchdarkly/node-server-sdk
npm install @launchdarkly/openfeature-node-server
```

### Usage
```
import { OpenFeature } from '@openfeature/js-sdk';
import { init } from 'launchdarkly-node-server-sdk';
import { init } from '@launchdarkly/node-server-sdk';
import { LaunchDarklyProvider } from '@launchdarkly/openfeature-node-server';


Expand Down
22 changes: 11 additions & 11 deletions __tests__/LaunchDarklyProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { OpenFeature, Client, ErrorCode } from '@openfeature/js-sdk';
import { LDClient } from 'launchdarkly-node-server-sdk';
import { LDClient } from '@launchdarkly/node-server-sdk';
import { LaunchDarklyProvider } from '../src';
import translateContext from '../src/translateContext';
import TestLogger from './TestLogger';
Expand Down Expand Up @@ -45,7 +45,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getBooleanDetails(testFlagKey, false, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
Copy link
Member Author

@kinyoklion kinyoklion Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OF SDK changed and returns extra stuff. Nothing related to our SDK update.

flagKey: testFlagKey,
value: true,
reason: 'OFF',
Expand All @@ -60,7 +60,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getBooleanDetails(testFlagKey, false, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: false,
reason: 'ERROR',
Expand Down Expand Up @@ -92,7 +92,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getStringDetails(testFlagKey, 'default', basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: 'good',
reason: 'OFF',
Expand All @@ -107,7 +107,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getStringDetails(testFlagKey, 'default', basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: 'default',
reason: 'ERROR',
Expand Down Expand Up @@ -139,7 +139,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getNumberDetails(testFlagKey, 0, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: 17,
reason: 'OFF',
Expand All @@ -154,7 +154,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getNumberDetails(testFlagKey, 0, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: 0,
reason: 'ERROR',
Expand Down Expand Up @@ -186,7 +186,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: { some: 'value' },
reason: 'OFF',
Expand All @@ -201,7 +201,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: {},
reason: 'ERROR',
Expand All @@ -225,7 +225,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: { yes: 'no' },
reason: 'ERROR',
Expand All @@ -242,7 +242,7 @@ describe('given a mock LaunchDarkly client', () => {
},
}));
const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext);
expect(res).toEqual({
expect(res).toMatchObject({
flagKey: testFlagKey,
value: { yes: 'no' },
variant: '22',
Expand Down
2 changes: 1 addition & 1 deletion __tests__/SafeLogger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { basicLogger, LDLogger } from 'launchdarkly-node-server-sdk';
import { basicLogger, LDLogger } from '@launchdarkly/node-server-sdk';
import SafeLogger from '../src/SafeLogger';

it('throws when constructed with an invalid logger', () => {
Expand Down
2 changes: 1 addition & 1 deletion __tests__/TestLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LDLogger } from 'launchdarkly-node-server-sdk';
import { LDLogger } from '@launchdarkly/node-server-sdk';

export default class TestLogger implements LDLogger {
public logs: string[] = [];
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"license": "Apache-2.0",
"peerDependencies": {
"@openfeature/js-sdk": "^1.0.0",
"launchdarkly-node-server-sdk": "7.x"
"@launchdarkly/node-server-sdk": "8.x"
},
"devDependencies": {
"@openfeature/js-sdk": "^1.0.0",
Expand All @@ -34,7 +34,7 @@
"eslint-plugin-import": "^2.26.0",
"jest": "^27.5.1",
"jest-junit": "^14.0.1",
"launchdarkly-node-server-sdk": "7.x",
"@launchdarkly/node-server-sdk": "8.x",
"ts-jest": "^27.1.4",
"typescript": "^4.7.4"
}
Expand Down
2 changes: 1 addition & 1 deletion src/LaunchDarklyProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
} from '@openfeature/js-sdk';
import {
basicLogger, LDClient, LDLogger,
} from 'launchdarkly-node-server-sdk';
} from '@launchdarkly/node-server-sdk';
import { LaunchDarklyProviderOptions } from './LaunchDarklyProviderOptions';
import translateContext from './translateContext';
import translateResult from './translateResult';
Expand Down
2 changes: 1 addition & 1 deletion src/LaunchDarklyProviderOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LDLogger } from 'launchdarkly-node-server-sdk';
import { LDLogger } from '@launchdarkly/node-server-sdk';

/**
* Options for the {@link LaunchDarklyProvider}.
Expand Down
2 changes: 1 addition & 1 deletion src/SafeLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LDLogger } from 'launchdarkly-node-server-sdk';
import { LDLogger } from '@launchdarkly/node-server-sdk';

/**
* Logging levels. Each should correspond to a method on the logger.
Expand Down
2 changes: 1 addition & 1 deletion src/translateContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { EvaluationContext, EvaluationContextValue } from '@openfeature/js-sdk';
import {
LDContext, LDContextCommon, LDLogger, LDSingleKindContext,
} from 'launchdarkly-node-server-sdk';
} from '@launchdarkly/node-server-sdk';

const LDContextBuiltIns = {
name: 'string',
Expand Down
2 changes: 1 addition & 1 deletion src/translateResult.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ErrorCode, ResolutionDetails } from '@openfeature/js-sdk';
import { LDEvaluationDetail } from 'launchdarkly-node-server-sdk';
import { LDEvaluationDetail } from '@launchdarkly/node-server-sdk';

/**
* Convert an `errorKind` into an OpenFeature `errorCode`.
Expand Down