feat: Provide access to HTTP headers on success or error #53
+438
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
changed the title
kinyoklion
reviewed
Nov 7, 2025
ld_eventsource/actions.py
Outdated
Comment on lines
129
to
130
| For HTTP-based connections, this contains the headers from the SSE response. | ||
| For non-HTTP connections, this will be ``None``. |
Member
There was a problem hiding this comment.
Do we need this section? I am always hesitant of "non-HTTP" SSE as a concept. But above we already say "if available", so we know it is optional.
kinyoklion
requested changes
Nov 7, 2025
kinyoklion
approved these changes
Nov 7, 2025
keelerm84
pushed a commit
that referenced
this pull request
Nov 7, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](1.4.0...1.5.0) (2025-11-07) ### Features * Provide access to HTTP headers on success or error ([#53](#53)) ([b83f356](b83f356)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.