feat: fall back to model.parameters.tools when root tools absent#146
Merged
jsonbailey merged 6 commits intomainfrom Apr 29, 2026
Merged
feat: fall back to model.parameters.tools when root tools absent#146jsonbailey merged 6 commits intomainfrom
jsonbailey merged 6 commits intomainfrom
Conversation
When a flag variation has no root-level `tools` key, resolve tools from `variation['model']['parameters']['tools']` instead. Root-level presence always takes priority; the model-params fallback is entirely silent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jsonbailey
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
keelerm84
approved these changes
Apr 29, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ools Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit da15718. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolve_tools()toclient.py— checks root-leveltoolsfirst, falls back tomodel.parameters.toolsfor older AI configstoolsalways takes priority when presentmodel.parameters.toolsas a list or non-dict is silently ignored (may be user-defined custom param)Background
The LaunchDarkly AI Config API now sends tools in two places: updated configs send them at both root and
model.parameters.tools; older configs only send them inmodel.parameters.tools. Previously the SDK only read root-level, leaving older configs with no tools.Test plan
model.parameters.toolswhen root key is absenttoolswins when both locations are presentmodel.parameters.toolsas list →NoneJira: AIC-1935
🤖 Generated with Claude Code
Note
Low Risk
Small, localized change to tool parsing/resolution with added tests; risk is limited to how tools are discovered from evaluated flag variations.
Overview
Adds backward-compatible tool resolution so
completion_configandagent_configcan load tools frommodel.parameters.toolswhen the root-leveltoolsfield is missing, while keeping roottoolsas the source of truth when both are present.Tightens tool parsing with warnings when
tools/model.parameters.toolsare present but not dicts, and expandstest_tools.pycoverage for fallback behavior, precedence, list/non-dict rejection, and skipping invalid tool entries.Reviewed by Cursor Bugbot for commit da15718. Bugbot is set up for automated code reviews on this repo. Configure here.