Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 6, 2026

Note

Prevents background availability polling after shutdown and clarifies store shutdown expectations.

  • Add __closed state to FeatureStoreClientWrapper, guard __update_availability when closed
  • Implement close() to stop any active RepeatingTask poller and forward close() to the underlying FeatureStore if present
  • Update interfaces.py with documentation/comments for optional FeatureStore.close() hook for resource cleanup

Written by Cursor Bugbot for commit e876d4b. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey marked this pull request as ready for review January 6, 2026 19:14
@jsonbailey jsonbailey requested a review from a team as a code owner January 6, 2026 19:14
Base automatically changed from jb/sdk-1710/lock-context-manager to main January 6, 2026 21:36
@jsonbailey jsonbailey merged commit 468afdf into main Jan 7, 2026
15 checks passed
@jsonbailey jsonbailey deleted the jb/close-polling-connection-on-close branch January 7, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants