fix: Fix incorrect event count in failure message #359
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
approved these changes
Oct 27, 2025
They are. I've been working on fixing those in the gh-actions repos. Re-running now and it should pass. |
keelerm84
pushed a commit
that referenced
this pull request
Oct 27, 2025
🤖 I have created a release *beep* *boop* --- ## [9.12.2](9.12.1...9.12.2) (2025-10-27) ### Bug Fixes * Fix incorrect event count in failure message ([#359](#359)) ([91f4163](91f4163)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 9.12.2 with a bug fix correcting the event count in a failure message and associated version/provenance updates. > > - **Release 9.12.2** > - Update version to `9.12.2` in `ldclient/version.py`, `pyproject.toml`, `.release-please-manifest.json`, and `PROVENANCE.md`. > - Update `CHANGELOG.md` with bug fix: correct incorrect event count in failure message. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit aca0ba7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Use
len(output_events)instead of bufferedlen(self._payload.events)when describing the number of events sent/retried.Written by Cursor Bugbot for commit c80cc86. This will update automatically on new commits. Configure here.