fix: Fix a race condition when handling multiple flag updates. #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/SDK-1442/unproxied-flag-state-management
branch
from
7025ddb to
1e60c36
Compare
kinyoklion
commented
Sep 29, 2025
| const reactOptions = this.getReactOptions(); | ||
| const updates = getFlattenedFlagsFromChangeset(changes, targetFlags); | ||
| const unproxiedFlags = { | ||
| ...this.state.unproxiedFlags, |
Member
Author
There was a problem hiding this comment.
The setState function is effectively asynchronous, multiple setState methods may be called in a single cycle before this.state is updated.
So if there were multiple dispatches of changes within a single batch, then some of the updates would be missed.
The way to handle this in react is to use the previous state provided using the method version of setState. The operations will be done sequentially with each having the correct view of the previous state.
abarker-launchdarkly
approved these changes
Sep 30, 2025
kinyoklion
deleted the
rlamb/SDK-1442/unproxied-flag-state-management
branch
kinyoklion
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [3.9.0](launchdarkly-react-client-sdk-v3.8.1...launchdarkly-react-client-sdk-v3.9.0) (2025-09-30) ### Features * Add experimental debug override functionality. ([63dd495](63dd495)) * Add experimental debug override functionality. ([4c4f3a3](4c4f3a3)) * Add experimental debug override functionality. ([#362](#362)) ([63dd495](63dd495)) ### Bug Fixes * Fix a race condition when handling multiple flag updates. ([#365](#365)) ([8d46bbd](8d46bbd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks for fixing this! 🙇 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setState function is effectively asynchronous, multiple setState methods may be called in a single cycle before this.state is updated.
So if there were multiple dispatches of changes within a single batch, then some of the updates could be missed.
The way to handle this in react is to use the previous state provided using the method version of setState. The operations will be done sequentially with each having the correct view of the previous state.