fix: parse FDv2 goodbye events with only a reason field#380
Merged
Conversation
The FDv2 goodbye event spec defines only a reason field, but the Goodbye class required silent and catastrophe — causing from_h to raise ArgumentError on spec-compliant payloads. Drop the extra fields and simplify the streaming handler to log the reason unconditionally.
kinyoklion
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goodbyeevent is specified to carry only areasonfield. The Ruby SDK'sGoodbyeclass incorrectly declaredsilentandcatastrophe, andfrom_hraisedArgumentErrorif either was missing — meaning a spec-compliant payload would fail to parse.to_h, andfrom_h.from_hnow requires onlyreason.lib/ldclient-rb/impl/data_system/streaming.rbwas logging at@logger.errorand readinggoodbye.silent/goodbye.catastrophe. Replaced with@logger.info { "[LDClient] SSE server received goodbye: #{goodbye.reason}" }— a goodbye is a normal protocol signal, matching the Java SDK.Test plan
bundle exec rspec spec/impl/data_system/streaming_synchronizer_spec.rb— 14 examples, 0 failures.bundle exec rspec spec/impl/data_system/— 125 examples, 0 failures.grep -rnforgoodbye.silent/goodbye.catastrophe— no remaining references.Note
Low Risk
Low risk: narrows
Goodbyeparsing/serialization to the spec-requiredreasonfield and adjusts logging; behavior change is limited to handlingGOODBYESSE events.Overview
Aligns FDv2
Goodbyeevent handling with the protocol by removing the unsupportedsilent/catastrophefields fromProtocolV2::Goodbye(constructor,to_h, andfrom_hnow only requirereason).Updates the streaming SSE consumer to stop treating
GOODBYEas an error condition and instead log it atinfo, and adjusts the streaming synchronizer spec to construct goodbye events with onlyreason.Reviewed by Cursor Bugbot for commit 17ff311. Bugbot is set up for automated code reviews on this repo. Configure here.