Skip to content

Conversation

eli-darkly
Copy link
Contributor

[5.0.0] - 2018-06-26

Changed:

  • The client no longer uses Celluloid for streaming I/O. Instead, it uses socketry.
  • The client now treats most HTTP 4xx errors as unrecoverable: that is, after receiving such an error, it will not make any more HTTP requests for the lifetime of the client instance, in effect taking the client offline. This is because such errors indicate either a configuration problem (invalid SDK key) or a bug, which is not likely to resolve without a restart or an upgrade. This does not apply if the error is 400, 408, 429, or any 5xx error.
  • During initialization, if the client receives any of the unrecoverable errors described above, the client constructor will return immediately; previously it would continue waiting until a timeout. The initialized? method will return false in this case.

Removed:

  • The SDK no longer supports Ruby versions below 2.2.6, or JRuby below 9.1.16.

eli-darkly and others added 30 commits June 13, 2018 18:02
fail fast in initialization if there's a 401
fail permanently on most 4xx errors
reimplement SSE client without Celluloid [1 of 2]
@eli-darkly eli-darkly requested a review from ashanbrown June 26, 2018 19:03
@eli-darkly eli-darkly merged commit afea4af into master Jun 26, 2018
@eli-darkly eli-darkly deleted the 5.0.0 branch June 26, 2018 20:17
eli-darkly pushed a commit that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants