Skip to content

Conversation

@iignatevich
Copy link
Collaborator

No description provided.

@iignatevich iignatevich linked an issue Jun 11, 2025 that may be closed by this pull request
@davidferlay
Copy link
Contributor

davidferlay commented Jun 11, 2025

Somehow it seems to break actions using ssh tunnel:

  • With fix:
➜ plx platform:data-bus list --cluster dev --keyring-passphrase-file /tmp/kp
Could not open a connection to your authentication agent.
2025/06/11 15:15:27 exit status 2
  ERROR   action "platform:data-bus" finished with exit code 1
  • Without fix:
➜ pl platform:data-bus list --cluster dev --keyring-passphrase-file /tmp/kp 
SSH_AUTH_SOCK=/tmp/socket; export SSH_AUTH_SOCK;
SSH_AGENT_PID=8; export SSH_AGENT_PID;
echo Agent pid 8;
Enter passphrase for /tmp/id_rsa: Identity added: /tmp/id_rsa (/tmp/id_rsa)
# 51.159.2.47:1337 SSH-2.0-OpenSSH_9.7
# 51.159.2.47:1337 SSH-2.0-OpenSSH_9.7
# 51.159.2.47:1337 SSH-2.0-OpenSSH_9.7
# 51.159.2.47:1337 SSH-2.0-OpenSSH_9.7
# 51.159.2.47:1337 SSH-2.0-OpenSSH_9.7
NAME                                                                                                                          PARTITIONS  REPLICAS
.metric                                                                                                                       5           1
fluent-bit                                                                                                                    5           1

All other actions looks ok

@iignatevich iignatevich force-pushed the 113-conflicting-argument-with---exec branch from e86b0ff to fca6330 Compare June 11, 2025 16:34
if rt, ok := a.Runtime().(action.RuntimeFlags); ok {
runtimeFlagsGroup := rt.GetFlags()
runOpts = derefOpts(filterChangedFlags(cmd, runOpts))
// @todo should we also set default values from runtimeFlagsGroup.GetAll?
Copy link
Collaborator

@lexbritvin lexbritvin Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this remark.
We should follow the same procedure as in Input parameters.

  1. A value must be nil if not given and if default is not provided.
  2. A value must be set to default if not changed.
  3. A value must be set to given if changed.

@iignatevich iignatevich force-pushed the 113-conflicting-argument-with---exec branch from fca6330 to 08ce179 Compare June 12, 2025 08:30
@davidferlay davidferlay merged commit 221e137 into main Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting argument with --exec

4 participants