Kubernetes #99
Merged
Kubernetes #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidferlay
|
|
@iignatevich @davidferlay |
|
Thanks @lexbritvin , Roger that, I'm gonna make regression tests and we will merge as is. About Image build is not supported yet. The image must exist in the available container registry. Any idea how to support that ? |
iignatevich
reviewed
May 14, 2025
| switch t { | ||
| case Docker: | ||
| return NewDockerDriver() | ||
| return NewDockerRuntime() |
There was a problem hiding this comment.
i think it should be named as New%TypeDriver or New%TypeRunner + renaming internal structs, as it's confusing with NewContainerRuntimeKubernetes and NewContainerRuntimeDocker
There was a problem hiding this comment.
Yes, it is confusing. And naming must be addressed here.
Driver is a bad naming. So we don't consider it for now.
I suggest that we cover the case when we rename the package driver to container.
A bit info about why so:
New%TypeRunner- we don't create a Type and we don't create a runner.- We create a client to
Runtime. See about Container Runtimes and CRI. Even though kubernetes is not exactly a runtime, for us it is. - In the action we also have Runtime, but it's about what is running the action. It can be function, shell, container.
- We also have
runtimepackage in go that describes the go language and os.
Please, let me know what you think about it.
There was a problem hiding this comment.
let's rename to container, but as discussed, need to rethink runtime (upper level) naming.
lexbritvin
commented
May 19, 2025
davidferlay
reviewed
May 19, 2025
davidferlay
reviewed
May 19, 2025
davidferlay
reviewed
May 19, 2025
davidferlay
reviewed
May 19, 2025
|
Bellow some feedbacks from first test -> just dropping here to be treated later in follow-ups Pods get created as expected locally with k3s:
Executing an action with container runtime fails with
Also had another kind of issue with another action: here are action files to reproduce: test-action.tar.gz |
|
Gonna start testing for regression to get PR merged soon |
|
Found some significant issues:
It seems to be reproduced everytime command fails or requires user input:
|
Fixed |
I think we should address that in the next refactorings. |
I'd rather opt for simplicity and either:
In any case, let's not bother with it now I'll create a specific task for it |
This was referenced May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.