Skip to content

Conversation

@SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 31, 2015

Dependencies already installed the same versions anyway, so no difference there.
Tests pass, so no problem bumping devDeps

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to work if mocha is not installed globally and paths are not setup correctly? I'd rather point at the locally installed version to be sure we're running what we installed instead of being at the mercy of paths. Feel free to set me straight if this understanding is not correct :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run-script prefixes node_modules/.bin to $PATH, so you're safe with this 😄

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent :)

lazd added a commit that referenced this pull request Mar 31, 2015
Bump dependencies, and test on latest Node as well as Io.js
@lazd lazd merged commit d77f4c7 into lazd:master Mar 31, 2015
@SimenB SimenB deleted the patch-1 branch March 31, 2015 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants