Skip to content

Fail build on linting error #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2015
Merged

Fail build on linting error #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .jscsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
},
"disallowQuotedKeysInObjects": true,
"disallowPaddingNewlinesInBlocks": true,
"disallowNewlineBeforeBlockStatements": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

"disallowSpacesInFunctionExpression": {
"beforeOpeningRoundBrace": true
},
Expand Down
3 changes: 2 additions & 1 deletion .jshintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"node": true,
"latedef": true,
"undef": true
"undef": true,
"unused": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered 2 unused, so just quickly added this 😄

}
1 change: 0 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ var gutil = require('gulp-util');
var c = gutil.colors;
var error = gutil.PluginError;
var es = require('event-stream');
var fs = require('fs');
var csslint = require('csslint').CSSLint;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason coverage is down

var RcLoader = require('rcloader');

Expand Down
16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,22 @@
],
"dependencies": {
"csslint": "^0.10.0",
"event-stream": "^3.3.0",
"event-stream": "^3.3.1",
"gulp-util": "^3.0.4",
"rcloader": "^0.1.4"
},
"devDependencies": {
"coveralls": "^2.11.2",
"istanbul": "^0.3.13",
"jscs": "^1.12.0",
"jshint": "^2.6.3",
"mocha": "^2.2.4",
"rimraf": "^2.3.2",
"should": "^5.2.0"
"istanbul": "^0.3.14",
"jscs": "^1.13.1",
"jshint": "^2.7.0",
"mocha": "^2.2.5",
"rimraf": "^2.3.4",
"should": "^6.0.3"
},
"scripts": {
"clean": "rimraf coverage/",
"lint": "jscs index.js test/ & jshint index.js test/",
"lint": "jscs index.js test/ && jshint index.js test/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra & is the real change. Stupid forking not playing nice 😆

"pretest": "npm run lint",
"test": "mocha",
"precover": "npm run lint && npm run clean",
Expand Down
2 changes: 1 addition & 1 deletion test/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('gulp-csslint', function() {
var file2 = getFile('fixtures/missingPrefixes.css');

var stream = cssLintPlugin();
stream.on('data', function(newFile) {
stream.on('data', function() {
++a;
});

Expand Down