Use eslint #31
Merged
Use eslint #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
this and the ones further down is npm alphabetizing
|
Besides the coding style differences and the lack of mergability, it's looking good! Please rebase and we'll merge it, I can play with the settings afterwards. |
|
This is using |
|
@SimenB yeah I'd rather have it match the coding style of my other projects and gulp plugins. Please do! |
|
@lazd Updated! |
Use SemiStandard with a small tweak to spaces
|
@lazd I see you changed some formatting now, updated this to follow those conventions |
|
This is looking good, I see several formatting fixes that make me happy, and it passes now. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently joined the bandwagon that is standard.
As you used semicolons i picked
semistandard.