Commit 881e3b2
authored
fix: Windows CI compatibility - resolve test_legend_comprehensive and test_streamplot failures (#363)
## Summary
- Fixes Windows CI failures in test_legend_comprehensive.exe and
test_streamplot.exe
- Adds platform-independent file system operation delays for Windows
compatibility
- Replaces error stop statements with traditional stop for better
Windows runtime compatibility
## Changes Made
- Added windows_safe_delay() subroutine using cpu_time intrinsic for
cross-platform delays
- Added 100ms delays after savefig() calls to allow Windows file system
operations to complete
- Added 150ms delay for PDF operations which may require more time on
Windows
- Replaced error stop with explicit print + stop 1 for consistent
behavior across platforms
## Root Cause Analysis
Windows CI failures were likely caused by:
1. **File system timing**: Windows filesystem operations may be slower
than Linux, causing file validation to fail before files are fully
written
2. **Runtime differences**: error stop behavior differs between
compilers/platforms
3. **I/O buffering**: Different file I/O buffering behavior on Windows
vs Linux
## Testing Strategy
- All delays use cpu_time intrinsic for platform independence
- No external dependencies added
- Maintains existing test validation logic
- Should not impact Linux CI performance significantly
## Fixes
- Fixes #361: Windows CI: test_legend_comprehensive and test_streamplot
runtime failures
This should resolve the Windows CI deadlock blocking PR merges in batch
mode operation.2 files changed
+47
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
| 53 | + | |
| 54 | + | |
50 | 55 | | |
51 | 56 | | |
52 | 57 | | |
| 58 | + | |
| 59 | + | |
53 | 60 | | |
54 | 61 | | |
| 62 | + | |
| 63 | + | |
55 | 64 | | |
| 65 | + | |
| 66 | + | |
56 | 67 | | |
57 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
58 | 72 | | |
59 | 73 | | |
60 | 74 | | |
| |||
97 | 111 | | |
98 | 112 | | |
99 | 113 | | |
| 114 | + | |
100 | 115 | | |
101 | 116 | | |
102 | 117 | | |
| |||
133 | 148 | | |
134 | 149 | | |
135 | 150 | | |
| 151 | + | |
136 | 152 | | |
137 | 153 | | |
138 | 154 | | |
| |||
173 | 189 | | |
174 | 190 | | |
175 | 191 | | |
| 192 | + | |
176 | 193 | | |
177 | 194 | | |
178 | 195 | | |
| |||
214 | 231 | | |
215 | 232 | | |
216 | 233 | | |
| 234 | + | |
217 | 235 | | |
218 | 236 | | |
219 | 237 | | |
| |||
244 | 262 | | |
245 | 263 | | |
246 | 264 | | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
247 | 279 | | |
248 | 280 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| 23 | + | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| 32 | + | |
28 | 33 | | |
| 34 | + | |
| 35 | + | |
29 | 36 | | |
30 | 37 | | |
31 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
32 | 42 | | |
33 | 43 | | |
34 | 44 | | |
| |||
73 | 83 | | |
74 | 84 | | |
75 | 85 | | |
76 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
77 | 90 | | |
78 | 91 | | |
79 | 92 | | |
0 commit comments