Add scam alert message when opening development tools.#1500
Merged
neb-b merged 3 commits intolbryio:masterfrom Jun 1, 2018
Merged
Add scam alert message when opening development tools.#1500neb-b merged 3 commits intolbryio:masterfrom
neb-b merged 3 commits intolbryio:masterfrom
Conversation
skhameneh
approved these changes
May 23, 2018
Member
|
Love the join us plug @dan1d :) |
|
I don't think this should be logged in dev mode |
neb-b
suggested changes
May 30, 2018
neb-b
left a comment
neb-b
left a comment
There was a problem hiding this comment.
Lets disable for dev mode then we can merge
Contributor
|
@dan1d tagging you to make sure you saw the above comment. |
Contributor
Author
|
Hi @seanyesmunt @tzarebczan |
neb-b
approved these changes
Jun 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've took the liberty to work on issue #1430 as the issue is 20 days old and OP didn't answered if he was going to work on this.
It closes issue: #1430, adds a warning message when development tools is opened on production, it can be disabled on development but is active by default.
Let me know if I should change the log message, or if while on development it should be disabled.