Skip to content

Conversation

@mickmis
Copy link
Contributor

@mickmis mickmis commented Dec 13, 2018

No description provided.

@mickmis mickmis requested a review from JoaoAndreSa December 13, 2018 10:54
@coveralls
Copy link

coveralls commented Dec 13, 2018

Coverage Status

Coverage remained the same at ?% when pulling be03a74 on docker into 9a86417 on master.

@JoaoAndreSa
Copy link
Contributor

JoaoAndreSa commented Jan 17, 2019

So @mickmis i tried to change onet to the stable version (in gopkg.in), but unfortunately I don't see a way to do this. Here is the main reason why:

gopkg.in/dedis/onet.v2 depends on gopkg.in/dedis/kyber.v2 in the sense that to use one we need to use the other. Problem is that this specific kyber "version" does not have a lot of stuff that we need for the unlynx library (e.g., there are no proofs/ and shuffle/ packages), which screws up all of our proofs :(, and our shuffling protocol). You might say: "but we don't use proofs for MedCo so why care!", but the problem is that proofs are integral part of all the protocols like deterministic tagging, shuffling, etc. and we cannot decouple them from the protocols. We can disable them using a flag (which is what we do and what makes sense), but that part of the code must still be compiled.

Our only option (I think!) is then to:

  • In the unlynx and medco-unlynx dockers whenever we do a release we make a note of the commit we used for onet and kyber and revert back both repos to these commits. Hopefully the v3 of both onet and kyber will include everything we need for unlynx/medco-unlynx to work properly and then we can migrate everything to this stable branch or keep using the previous system.

Let me know what you think....

@mickmis
Copy link
Contributor Author

mickmis commented Jan 17, 2019

Okay, so as said let's go for keeping the development version with a specific commit until the v3.
Only the unlynx docker image needs to do that (the other images extend this one).

I will modify the Dockerfile to do that, let me know :

  • what repos should have a specific commit (onet, kyber, other?)
  • what commit should be used for each of them

@mickmis mickmis closed this Jan 17, 2019
@mickmis mickmis reopened this Jan 17, 2019
@mickmis mickmis merged commit ac45810 into master Jan 17, 2019
@mickmis mickmis deleted the docker branch January 17, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants