Draft: Adding generic functions to LPython #625

ansharlubis · 2022-06-17T20:14:18Z

No description provided.

certik · 2022-06-18T16:17:25Z

Can you please resolve conflicts and add tests?

ansharlubis · 2022-06-20T02:50:53Z

About the conflict, I'm not sure what CPtr() and boolop are, so I can't decide on what should be done with those.

About the tests, currently there is no code generation for type variables, so what kind of test should I make? Also I am not familiar with the steps to add tests.

certik · 2022-06-20T04:06:49Z

@ansharlubis see if you can rebase this on top of the latest main. Simply at the end, your additions should look the same, just on top of the latest main. Start with that. Then we can talk about tests. If you get stuck, please let me know right away, and I'll help.

certik · 2022-06-20T05:56:17Z

src/libasr/ASR.asdl

@@ -317,6 +317,10 @@ ttype
    | Dict(ttype key_type, ttype value_type)
    | Pointer(ttype type)
    | CPtr()
+    | TypeVar(string var)
+
+boolop = And | Or | Xor | NEqv | Eqv


You can probably remove this, we don't need it for this PR.

I need the | TypeVar(String var) for handling type variable declaration.

You need TypeVar, but you do not need the extra boolop.

certik · 2022-06-20T05:59:39Z

Now when it is merged with the latest main, the next step is to add a test for this. I think this takes Python code and converts it to ASR? If so, then add a test into the tests directory and register it in tests.toml.

ansharlubis · 2022-06-20T06:20:47Z

Now when it is merged with the latest main, the next step is to add a test for this. I think this takes Python code and converts it to ASR? If so, then add a test into the tests directory and register it in tests.toml.

How do I define the reference for the test?

certik · 2022-06-20T06:32:34Z

You run ./run_tests.py -u, it will generate it. Then you commit it to git.

ansharlubis · 2022-06-20T08:03:04Z

I seem to run into problem with test_numpy_02.py where TypeVar was used as follows.

n: i32
n = TypeVar('n')

What is the purpose of TypeVar here?

certik · 2022-06-20T08:17:44Z

In there the purpose is to declare n so that it can be used in type annotations for arrays.

certik · 2022-07-06T16:21:37Z

For inspiration:

certik · 2022-07-06T16:55:11Z

TODO:

Implement function duplication, with a name change
Go into the new function and change all templates T to the new type
Call the new function
Update the unused function visitor to remove all templated functions, so that it can be compiled with the LLVM backend.

certik · 2022-08-01T08:18:50Z

tests/reference/asr-generics_sum_01-b85ce39.stderr

@@ -0,0 +1,57 @@
+Traceback (most recent call last):


This file should be removed.

certik · 2022-08-01T08:19:39Z

tests/tests.toml

+[[test]]
+filename = "../integration_tests/generics_01.py"
+asr = true
+llvm = true


I don't think we need to test llvm, since we are not modifying anything in the backend. Rather, let's add an integration test, to ensure it builds and runs.

Okay got it. I've already added the integration test.

certik · 2022-08-01T08:20:01Z

tests/tests.toml

+[[test]]
+filename = "../integration_tests/generics_array_01.py"
+asr = true
+llvm = true


Same here, let's add an integration test and remove llvm here.

Keep testing asr, that is good.

certik · 2022-08-01T08:20:46Z

What is the status of this and #831? Let's get it finished so that we can merge.

ansharlubis · 2022-08-01T08:55:29Z

What is the status of this and #831? Let's get it finished so that we can merge.

Both pass the checks. But this PR and #831 have different ASR structures.

…example

certik · 2022-08-04T11:51:03Z

We do not need to work on this one, since we are merging #831, so I'll close this one.

Added type variable to ASR and type variable binding to the symbol table

0e94ccd

ansharlubis added 2 commits June 20, 2022 14:40

Fix conflict in ASR grammar

77651cc

Merge branch 'main' into type-var

e3d2c76

certik reviewed Jun 20, 2022

View reviewed changes

ansharlubis added 5 commits June 20, 2022 15:44

Merge ASR.asdl

df5ca4f

Deal with conflict and test

093b1b0

ASR grammar

2bee38b

ASR.asdl fix

5a68fee

Add test var reference

a0002c2

ansharlubis added 3 commits June 21, 2022 15:11

Moved TestVar handling to visit assign in symbol table visitor

f53bc5b

Allow type parameter substitutions by function calls

21ef3c0

Overloaded generic functions, elaborate type parameter errors

00d877b

ansharlubis and others added 8 commits July 12, 2022 12:07

Moved template function handler to body visitor

cdbd963

Update tests for typevar

a0803fb

Handle similar function instantiations

eeee352

Add example

3c75a26

Merge branch 'main' into type-var

caf28db

Better verify error message

858e32c

Handle TemplateFunction_t

311810f

Improve the verify and utils

61b0b8c

Update test references without template function

3a9337a

certik reviewed Aug 1, 2022

View reviewed changes

ansharlubis added 12 commits August 1, 2022 18:48

Removed traces of template function

d70ebea

Minimize implementation

59d392e

Remove unnecessary tests

5085ff0

Merge remote-tracking branch 'upstream/main' into remove-template

d0796d0

Comment out not working tests

d5a756a

Added support for other types

f1ddefe

Updated tests, ignore element test

6ee0852

Remove sum tets

9920246

Removed llvm tests for generics

bf7d46d

Allow list item duplication during function instantiation

13cf369

Add ASR test for list

10f4ee3

Added the list test file

b18cfc2

ansharlubis force-pushed the type-var branch from fdcad25 to b18cfc2 Compare August 2, 2022 10:25

ansharlubis added 9 commits August 2, 2022 19:27

Update tests

d7b2a08

Fixing issues from the rebase

f460302

Merge branch 'main' into type-var

6f34a20

Update the elemental tests

32d1fdf

Added very simple implemetation of restrictions, break older generics

77e2930

Comment out older generic tests, update tests

bb45b2a

Update older generic tests with trait, CPython fails with the simple …

36f406e

…example

Update tests again

84e559e

Fixing the elemental

462a163

certik closed this Aug 4, 2022

Draft: Adding generic functions to LPython #625

Draft: Adding generic functions to LPython #625

Uh oh!

Conversation

ansharlubis commented Jun 17, 2022

Uh oh!

certik commented Jun 18, 2022

Uh oh!

ansharlubis commented Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

certik commented Jun 20, 2022

Uh oh!

certik Jun 20, 2022

Choose a reason for hiding this comment

Uh oh!

ansharlubis Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

certik Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

certik commented Jun 20, 2022

Uh oh!

ansharlubis commented Jun 20, 2022

Uh oh!

certik commented Jun 20, 2022

Uh oh!

ansharlubis commented Jun 20, 2022

Uh oh!

certik commented Jun 20, 2022

Uh oh!

certik commented Jul 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

certik commented Jul 6, 2022

Uh oh!

certik Aug 1, 2022

Choose a reason for hiding this comment

Uh oh!

certik Aug 1, 2022

Choose a reason for hiding this comment

Uh oh!

ansharlubis Aug 1, 2022

Choose a reason for hiding this comment

Uh oh!

certik Aug 1, 2022

Choose a reason for hiding this comment

Uh oh!

certik commented Aug 1, 2022

Uh oh!

ansharlubis commented Aug 1, 2022

Uh oh!

certik commented Aug 4, 2022

Uh oh!

Uh oh!

ansharlubis commented Jun 20, 2022 •

edited

Loading

ansharlubis Jun 20, 2022 •

edited

Loading

certik commented Jul 6, 2022 •

edited

Loading