Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Conversation

@undoingtech
Copy link

Regarding issue #326. Added controls variable and parameter to the starttls example.

};

client.starttls(opts, function(err, res) {
var controls = client.controls;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note about why we are doing this?

@undoingtech
Copy link
Author

I think I made a mistake with this PR. I was under the impression that the controls parameter was required. Technically the controls parameter is required as currently implimented, but it should be optional (as according to the "Common patterns" section in client API documentation).

I would rather fix the code than update the documentation.

I suggest this PR be closed/rejected. I will start a new PR where I fix the starttls function so the controls parameter is optional.

@undoingtech undoingtech deleted the 326-how-to-use-starttls branch August 11, 2020 13:31
@jsumners
Copy link
Member

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants