This repository was archived by the owner on May 14, 2024. It is now read-only.
Fix node-ldapjs#329 #773
Closed
Fix node-ldapjs#329 #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
suggested changes
Dec 3, 2021
Comment on lines
1275
to
+1281
| try { | ||
| return conn.write(message.toBer(), writeCallback) | ||
| if (expect === 'unbind') { | ||
| return conn.write(message.toBer(), writeCallback) | ||
| } else { | ||
| writeCallback() | ||
| return conn.write(message.toBer()) | ||
| } |
Member
There was a problem hiding this comment.
At a minimum we should have a comment here that explains why this code is the way it is. This would at least allow us to accept it without a test, as I know there is difficult code in this project. However, we really should be able to force the condition in our unit tests somehow.
Member
|
👋 On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request. Please see issue #839 for more information, including how to proceed if you feel this closure is in error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #329. This is a small improvement over the code changes proposed in the thread of #329, which break the server.test.
There is no test included because the error is caused by a race condition and I can't reproduce it reliably.