Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

feat(order/rel_iso/basic): add rel_covering, main defs only#18418

Open
astrainfinita wants to merge 3 commits intomasterfrom
FR_rel_covering
Open

feat(order/rel_iso/basic): add rel_covering, main defs only#18418
astrainfinita wants to merge 3 commits intomasterfrom
FR_rel_covering

Conversation

@astrainfinita
Copy link
Copy Markdown
Collaborator

@astrainfinita astrainfinita commented Feb 10, 2023

rel_covering is the dual concept of rel_embedding. It preserves and reflects is_irrefl is_asymm acc well_founded between relations. An important example is quotient.mk between the relation and the quotient.lift₂ of the relation.

See #18128 for more details.


Open in Gitpod

@astrainfinita astrainfinita added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy labels Feb 10, 2023
@astrainfinita astrainfinita changed the title feat(order/rel_iso/basic): add rel_covering, defs only feat(order/rel_iso/basic): add rel_covering, main defs only Feb 10, 2023
@astrainfinita astrainfinita requested a review from a team as a code owner February 10, 2023 07:13
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 10, 2023
@eric-wieser
Copy link
Copy Markdown
Member

Please add the relevant details to this PR description, and not just a link to another PR.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 10, 2023
@astrainfinita astrainfinita added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 11, 2023
@eric-wieser
Copy link
Copy Markdown
Member

What's the motivation for this new bundling? Do you have an application in mind?

The benefit feels pretty marginal in the face of the boilerplate and forward-porting effort, unless this is working towards a bigger goal.

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes merge-conflict Please `git merge origin/master` then a bot will remove this label. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. and removed awaiting-review The author would like community review of the PR labels Mar 28, 2023
@kim-em kim-em added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@kim-em kim-em removed the request for review from a team August 6, 2023 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-author A reviewer has asked the author a question or requested changes merge-conflict Please `git merge origin/master` then a bot will remove this label. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-order Order hierarchy too-late This PR was ready too late for inclusion in mathlib3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants