Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

refactor(data/list/nat_antidiagonal): extend to enat#18581

Open
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/antidiagonal-with_bot
Open

refactor(data/list/nat_antidiagonal): extend to enat#18581
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/antidiagonal-with_bot

Conversation

@eric-wieser
Copy link
Copy Markdown
Member


Open in Gitpod

@eric-wieser eric-wieser added the WIP Work in progress label Mar 14, 2023
@eric-wieser eric-wieser requested a review from YaelDillies March 14, 2023 14:40
@@ -28,59 +31,80 @@ namespace list
namespace nat

/-- The antidiagonal of a natural number `n` is the list of pairs `(i, j)` such that `i + j = n`. -/
Copy link
Copy Markdown
Collaborator

@YaelDillies YaelDillies Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- The antidiagonal of a natural number `n` is the list of pairs `(i, j)` such that `i + j = n`. -/
/-- The antidiagonal of a natural number `n` is the list of pairs `(i, j)` such that `i + j = n`.
As a special case, `list.nat_antidiagonal \bot = []`. -/

@urkud
Copy link
Copy Markdown
Member

urkud commented Mar 18, 2023

enat is with_top nat, not with_bot nat.

@kim-em kim-em added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

too-late This PR was ready too late for inclusion in mathlib3 WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants